Re: [Xen-devel] [PATCH v3 4/4] xen: use SYMBOL everywhere

2018-11-12 Thread Stefano Stabellini
On Mon, 12 Nov 2018, Julien Grall wrote: > Hi Stefano, > > On 11/8/18 10:27 PM, Stefano Stabellini wrote: > > On Thu, 8 Nov 2018, Jan Beulich wrote: > > > > > > On 06.11.18 at 23:05, wrote: > > > > Use SYMBOL everywhere _stext, _etext, etc. are used. Technically, it > > > > is required when compa

Re: [Xen-devel] [PATCH v3 4/4] xen: use SYMBOL everywhere

2018-11-12 Thread Julien Grall
Hi Stefano, On 11/8/18 10:27 PM, Stefano Stabellini wrote: On Thu, 8 Nov 2018, Jan Beulich wrote: On 06.11.18 at 23:05, wrote: Use SYMBOL everywhere _stext, _etext, etc. are used. Technically, it is required when comparing and subtracting pointers [1], but use it everywhere to avoid confusion

Re: [Xen-devel] [PATCH v3 4/4] xen: use SYMBOL everywhere

2018-11-09 Thread Stefano Stabellini
On Fri, 9 Nov 2018, Julien Grall wrote: > Hi Stefano, > > On 06/11/2018 22:05, Stefano Stabellini wrote: > > Use SYMBOL everywhere _stext, _etext, etc. are used. Technically, it > > is required when comparing and subtracting pointers [1], but use it > > everywhere to avoid confusion. > > > > M3CM

Re: [Xen-devel] [PATCH v3 4/4] xen: use SYMBOL everywhere

2018-11-09 Thread Julien Grall
Hi Stefano, On 06/11/2018 22:05, Stefano Stabellini wrote: Use SYMBOL everywhere _stext, _etext, etc. are used. Technically, it is required when comparing and subtracting pointers [1], but use it everywhere to avoid confusion. M3CM: Rule-18.2: Subtraction between pointers shall only be applied

Re: [Xen-devel] [PATCH v3 4/4] xen: use SYMBOL everywhere

2018-11-08 Thread Jan Beulich
>>> On 08.11.18 at 23:27, wrote: > On Thu, 8 Nov 2018, Jan Beulich wrote: >> >>> On 06.11.18 at 23:05, wrote: >> > --- >> > xen/arch/arm/alternative.c | 7 ++-- >> > xen/arch/arm/arm32/livepatch.c | 2 +- >> > xen/arch/arm/arm64/livepatch.c | 2 +- >> > xen/arch/arm/domain_

Re: [Xen-devel] [PATCH v3 4/4] xen: use SYMBOL everywhere

2018-11-08 Thread Stefano Stabellini
On Thu, 8 Nov 2018, Jan Beulich wrote: > >>> On 06.11.18 at 23:05, wrote: > > Use SYMBOL everywhere _stext, _etext, etc. are used. Technically, it > > is required when comparing and subtracting pointers [1], but use it > > everywhere to avoid confusion. > > I think using it when not needed is cau

Re: [Xen-devel] [PATCH v3 4/4] xen: use SYMBOL everywhere

2018-11-08 Thread Jan Beulich
>>> On 06.11.18 at 23:05, wrote: > Use SYMBOL everywhere _stext, _etext, etc. are used. Technically, it > is required when comparing and subtracting pointers [1], but use it > everywhere to avoid confusion. I think using it when not needed is causing more confusion. Also why would you then not us

[Xen-devel] [PATCH v3 4/4] xen: use SYMBOL everywhere

2018-11-06 Thread Stefano Stabellini
Use SYMBOL everywhere _stext, _etext, etc. are used. Technically, it is required when comparing and subtracting pointers [1], but use it everywhere to avoid confusion. M3CM: Rule-18.2: Subtraction between pointers shall only be applied to pointers that address elements of the same array [1] http