On Thu, Jul 05, 2018 at 11:42:34AM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH v3 3/6] libxc: allow HVM guest to have modules"):
> > On Thu, Jul 05, 2018 at 11:29:41AM +0100, Ian Jackson wrote:
> > > AIUI you mean something more like
> > >
> > > Now the code needs to handle virt_base
On Thu, Jul 05, 2018 at 11:42:50AM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH v3 3/6] libxc: allow HVM guest to have modules"):
> > In case virt_base is not set, it should be treated as zero.
>
> Why ?
Virt_base is the virtual address base for loading a binary. If it is not
set it sh
Wei Liu writes ("Re: [PATCH v3 3/6] libxc: allow HVM guest to have modules"):
> On Thu, Jul 05, 2018 at 11:29:41AM +0100, Ian Jackson wrote:
> > AIUI you mean something more like
> >
> > Now the code needs to handle virt_base being UNSET_ADDR, which it is
> > for HVM guests. In that case seg.
Wei Liu writes ("Re: [PATCH v3 3/6] libxc: allow HVM guest to have modules"):
> In case virt_base is not set, it should be treated as zero.
Why ?
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listin
On Thu, Jul 05, 2018 at 11:34:27AM +0100, Wei Liu wrote:
> On Thu, Jul 05, 2018 at 11:29:41AM +0100, Ian Jackson wrote:
> > Wei Liu writes ("[PATCH v3 3/6] libxc: allow HVM guest to have modules"):
> > > Lift the loading code out of PVH specific branch. Take the chance to
> > > make the debug messa
On Thu, Jul 05, 2018 at 11:29:41AM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH v3 3/6] libxc: allow HVM guest to have modules"):
> > Lift the loading code out of PVH specific branch. Take the chance to
> > make the debug message more useful. Now the code needs to take into
> > account virt
Wei Liu writes ("[PATCH v3 3/6] libxc: allow HVM guest to have modules"):
> Lift the loading code out of PVH specific branch. Take the chance to
> make the debug message more useful. Now the code needs to take into
> account virt_base.
I'm afraid this commit message's note about virt_base is a bi
Lift the loading code out of PVH specific branch. Take the chance to
make the debug message more useful. Now the code needs to take into
account virt_base.
IPXE will be loaded as a module of Rombios.
Signed-off-by: Wei Liu
Reviewed-by: Roger Pau Monné
---
Cc: Ian Jackson
---
tools/libxc/xc_d
