Re: [Xen-devel] [PATCH v3 3/3] xen/x86: declare the efi symbol as weak

2018-07-13 Thread Daniel Kiper
On Thu, Jul 12, 2018 at 06:37:33PM +0200, Roger Pau Monné wrote: > On Thu, Jul 12, 2018 at 01:35:14PM +0200, Daniel Kiper wrote: > > On Wed, Jul 11, 2018 at 05:34:50PM +0200, Roger Pau Monne wrote: > > > This allows removing the DEFINED conditional in the linker script, and > > > fixes compilation

Re: [Xen-devel] [PATCH v3 3/3] xen/x86: declare the efi symbol as weak

2018-07-12 Thread Roger Pau Monné
On Thu, Jul 12, 2018 at 01:35:14PM +0200, Daniel Kiper wrote: > On Wed, Jul 11, 2018 at 05:34:50PM +0200, Roger Pau Monne wrote: > > This allows removing the DEFINED conditional in the linker script, and > > fixes compilation with lld: > > s/lld/LLVM linker/? > > Could you mention the version of

Re: [Xen-devel] [PATCH v3 3/3] xen/x86: declare the efi symbol as weak

2018-07-12 Thread Jan Beulich
>>> On 12.07.18 at 13:35, wrote: > On Wed, Jul 11, 2018 at 05:34:50PM +0200, Roger Pau Monne wrote: >> This allows removing the DEFINED conditional in the linker script, and >> fixes compilation with lld: > > s/lld/LLVM linker/? > > Could you mention the version of LLVM linker in the commit mess

Re: [Xen-devel] [PATCH v3 3/3] xen/x86: declare the efi symbol as weak

2018-07-12 Thread Daniel Kiper
On Wed, Jul 11, 2018 at 05:34:50PM +0200, Roger Pau Monne wrote: > This allows removing the DEFINED conditional in the linker script, and > fixes compilation with lld: s/lld/LLVM linker/? Could you mention the version of LLVM linker in the commit message? And I am still not sure why do you insist

[Xen-devel] [PATCH v3 3/3] xen/x86: declare the efi symbol as weak

2018-07-11 Thread Roger Pau Monne
This allows removing the DEFINED conditional in the linker script, and fixes compilation with lld: ld-melf_x86_64_fbsd -T xen.lds -N prelink.o --build-id=sha1 \ /root/src/xen/xen/common/symbols-dummy.o -o /root/src/xen/xen/.xen-syms.0 ld: error: xen.lds:233: symbol not found: efi Signed-