Re: [Xen-devel] [PATCH v3 3/3] x86: check for multiboot{1, 2} header presence

2019-06-27 Thread Roger Pau Monné
On Thu, Jun 27, 2019 at 12:51:05PM +0100, Andrew Cooper wrote: > On 27/06/2019 10:33, Roger Pau Monne wrote: > > diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile > > index 8a8d8f060f..94e6c9aee3 100644 > > --- a/xen/arch/x86/Makefile > > +++ b/xen/arch/x86/Makefile > > @@ -99,9 +99,14 @@

Re: [Xen-devel] [PATCH v3 3/3] x86: check for multiboot{1, 2} header presence

2019-06-27 Thread Andrew Cooper
On 27/06/2019 13:10, Jan Beulich wrote: On 27.06.19 at 13:51, wrote: >> On 27/06/2019 10:33, Roger Pau Monne wrote: >>> diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile >>> index 8a8d8f060f..94e6c9aee3 100644 >>> --- a/xen/arch/x86/Makefile >>> +++ b/xen/arch/x86/Makefile >>> @@ -99

Re: [Xen-devel] [PATCH v3 3/3] x86: check for multiboot{1, 2} header presence

2019-06-27 Thread Jan Beulich
>>> On 27.06.19 at 13:51, wrote: > On 27/06/2019 10:33, Roger Pau Monne wrote: >> diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile >> index 8a8d8f060f..94e6c9aee3 100644 >> --- a/xen/arch/x86/Makefile >> +++ b/xen/arch/x86/Makefile >> @@ -99,9 +99,14 @@ endif >> syms-warn-dup-y := --war

Re: [Xen-devel] [PATCH v3 3/3] x86: check for multiboot{1, 2} header presence

2019-06-27 Thread Andrew Cooper
On 27/06/2019 10:33, Roger Pau Monne wrote: > diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile > index 8a8d8f060f..94e6c9aee3 100644 > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @@ -99,9 +99,14 @@ endif > syms-warn-dup-y := --warn-dup > syms-warn-dup-$(CONFIG_SUPPRESS_D

Re: [Xen-devel] [PATCH v3 3/3] x86: check for multiboot{1, 2} header presence

2019-06-27 Thread Jan Beulich
>>> On 27.06.19 at 11:33, wrote: > After building the hypervisor binary. Note that the check is performed > by searching for the magic header value at the start of the binary. > > Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich ___ Xen-devel m

[Xen-devel] [PATCH v3 3/3] x86: check for multiboot{1, 2} header presence

2019-06-27 Thread Roger Pau Monne
After building the hypervisor binary. Note that the check is performed by searching for the magic header value at the start of the binary. Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu --- Changes since v2: - Use a variable to store the intermediate file nam