Re: [Xen-devel] [PATCH v3 10/31] libxl_qmp: Move buffers to the stack of qmp_next.

2018-06-28 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH v3 10/31] libxl_qmp: Move buffers to the stack of qmp_next."): > On Wed, Jun 27, 2018 at 03:32:32PM +0100, Ian Jackson wrote: > > Anthony PERARD writes ("[PATCH v3 10/31] libxl_qmp: Move buffers to the > > stack of qmp_next."): > > > That buffer is only used loc

Re: [Xen-devel] [PATCH v3 10/31] libxl_qmp: Move buffers to the stack of qmp_next.

2018-06-27 Thread Anthony PERARD
On Wed, Jun 27, 2018 at 03:32:32PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH v3 10/31] libxl_qmp: Move buffers to the stack > of qmp_next."): > > That buffer is only used locally, and never reuse accross different call > > of qmp_next. So remove it form the handler. > > How big i

Re: [Xen-devel] [PATCH v3 10/31] libxl_qmp: Move buffers to the stack of qmp_next.

2018-06-27 Thread Ian Jackson
Anthony PERARD writes ("[PATCH v3 10/31] libxl_qmp: Move buffers to the stack of qmp_next."): > That buffer is only used locally, and never reuse accross different call > of qmp_next. So remove it form the handler. How big is this buffer ? I think you're moving it from the heap to the stack ? D

[Xen-devel] [PATCH v3 10/31] libxl_qmp: Move buffers to the stack of qmp_next.

2018-06-01 Thread Anthony PERARD
That buffer is only used locally, and never reuse accross different call of qmp_next. So remove it form the handler. Signed-off-by: Anthony PERARD --- tools/libxl/libxl_qmp.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/li