Re: [Xen-devel] [PATCH v3 1/1] xen: fix handling framebuffer located above 4GB

2019-05-16 Thread Marek Marczykowski
On Thu, May 16, 2019 at 08:59:36AM -0600, Jan Beulich wrote: > >>> On 16.05.19 at 16:07, wrote: > > --- a/xen/drivers/video/vesa.c > > +++ b/xen/drivers/video/vesa.c > > @@ -40,6 +40,11 @@ static int __init parse_font_height(const char *s) > > } > > custom_param("font", parse_font_height); > >

Re: [Xen-devel] [PATCH v3 1/1] xen: fix handling framebuffer located above 4GB

2019-05-16 Thread Jan Beulich
>>> On 16.05.19 at 16:07, wrote: > --- a/xen/drivers/video/vesa.c > +++ b/xen/drivers/video/vesa.c > @@ -40,6 +40,11 @@ static int __init parse_font_height(const char *s) > } > custom_param("font", parse_font_height); > > +static inline paddr_t lfb_base(void) > +{ > +return (paddr_t)((vlfb

[Xen-devel] [PATCH v3 1/1] xen: fix handling framebuffer located above 4GB

2019-05-16 Thread Marek Marczykowski-Górecki
On some machines (for example Thinkpad P52), UEFI GOP reports framebuffer located above 4GB (0x40 on that machine). This address does not fit in {xen,dom0}_vga_console_info.u.vesa_lfb.lfb_base field, which is 32bit. The overflow here cause all kind of memory corruption when anything tries t