Re: [Xen-devel] [PATCH v3] xen: avoid crash in disable_hotplug_cpu

2018-09-11 Thread Juergen Gross
On 11/09/18 16:29, Boris Ostrovsky wrote: > On 9/11/18 7:25 AM, Juergen Gross wrote: >> >> Reviewed-by: Juergen Gross > > So is it v3 or v4, you gave R-b for both. (I slightly prefer v3, but > either is fine). V4 is better as it does the online test only after acquiring the hotplug lock. Juerg

Re: [Xen-devel] [PATCH v3] xen: avoid crash in disable_hotplug_cpu

2018-09-11 Thread Boris Ostrovsky
On 9/11/18 7:25 AM, Juergen Gross wrote: > > Reviewed-by: Juergen Gross So is it v3 or v4, you gave R-b for both. (I slightly prefer v3, but either is fine). -boris ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org

Re: [Xen-devel] [PATCH v3] xen: avoid crash in disable_hotplug_cpu

2018-09-11 Thread Juergen Gross
On 07/09/18 08:30, Olaf Hering wrote: > The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0: > > BUG: unable to handle kernel NULL pointer dereference at 02d8 > PGD 0 P4D 0 > Oops: [#1] PREEMPT SMP NOPTI > CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga9462db-

Re: [Xen-devel] [PATCH v3] xen: avoid crash in disable_hotplug_cpu

2018-09-07 Thread Olaf Hering
Am Fri, 7 Sep 2018 09:33:20 -0400 schrieb Boris Ostrovsky : > what is the purpose of 'xl vcpu-set 0'? Likely just a script that went wrong. But that command should not break the dom0. Olaf pgpf7yM3gq1fu.pgp Description: Digitale Signatur von OpenPGP __

Re: [Xen-devel] [PATCH v3] xen: avoid crash in disable_hotplug_cpu

2018-09-07 Thread Boris Ostrovsky
On 09/07/2018 02:30 AM, Olaf Hering wrote: > The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0: > > BUG: unable to handle kernel NULL pointer dereference at 02d8 > PGD 0 P4D 0 > Oops: [#1] PREEMPT SMP NOPTI > CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga946

Re: [Xen-devel] [PATCH v3] xen: avoid crash in disable_hotplug_cpu

2018-09-07 Thread Juergen Gross
On 07/09/18 11:24, Olaf Hering wrote: > Am Fri, 7 Sep 2018 09:48:28 +0200 > schrieb Juergen Gross : > >> On 07/09/18 08:30, Olaf Hering wrote: >>> + if (cpu_online(cpu)) >>> + return; >>> if (cpu_present(cpu)) >>> xen_arch_unregister_cpu(cpu); > >> Could you merge th

Re: [Xen-devel] [PATCH v3] xen: avoid crash in disable_hotplug_cpu

2018-09-07 Thread Olaf Hering
Am Fri, 7 Sep 2018 09:48:28 +0200 schrieb Juergen Gross : > On 07/09/18 08:30, Olaf Hering wrote: > > + if (cpu_online(cpu)) > > + return; > > if (cpu_present(cpu)) > > xen_arch_unregister_cpu(cpu); > Could you merge the two if conditions? > if (!cpu_online(cpu) && c

Re: [Xen-devel] [PATCH v3] xen: avoid crash in disable_hotplug_cpu

2018-09-07 Thread Juergen Gross
On 07/09/18 08:30, Olaf Hering wrote: > The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0: > > BUG: unable to handle kernel NULL pointer dereference at 02d8 > PGD 0 P4D 0 > Oops: [#1] PREEMPT SMP NOPTI > CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga9462db-

[Xen-devel] [PATCH v3] xen: avoid crash in disable_hotplug_cpu

2018-09-06 Thread Olaf Hering
The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0: BUG: unable to handle kernel NULL pointer dereference at 02d8 PGD 0 P4D 0 Oops: [#1] PREEMPT SMP NOPTI CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga9462db-default #1 openSUSE Tumbleweed (unreleased) Hardw