Re: [Xen-devel] [PATCH v2 6/7] x86/mm: handle foreign mappings in p2m_entry_modify

2019-02-14 Thread Jan Beulich
>>> On 14.02.19 at 13:12, wrote: > On Thu, Feb 14, 2019 at 04:25:49AM -0700, Jan Beulich wrote: >> >>> On 11.02.19 at 18:46, wrote: >> > @@ -948,6 +951,11 @@ static inline void p2m_entry_modify(struct p2m_domain >> > *p2m, p2m_type_t nt, >> > p2m->ioreq.entry_count++; >> > brea

Re: [Xen-devel] [PATCH v2 6/7] x86/mm: handle foreign mappings in p2m_entry_modify

2019-02-14 Thread Roger Pau Monné
On Thu, Feb 14, 2019 at 04:25:49AM -0700, Jan Beulich wrote: > >>> On 11.02.19 at 18:46, wrote: > > @@ -948,6 +951,11 @@ static inline void p2m_entry_modify(struct p2m_domain > > *p2m, p2m_type_t nt, > > p2m->ioreq.entry_count++; > > break; > > > > +case p2m_map_foreign: >

Re: [Xen-devel] [PATCH v2 6/7] x86/mm: handle foreign mappings in p2m_entry_modify

2019-02-14 Thread Jan Beulich
>>> On 11.02.19 at 18:46, wrote: > @@ -948,6 +951,11 @@ static inline void p2m_entry_modify(struct p2m_domain > *p2m, p2m_type_t nt, > p2m->ioreq.entry_count++; > break; > > +case p2m_map_foreign: > +BUG_ON(!mfn_valid(nfn) || > + !page_get_owner_and_r

[Xen-devel] [PATCH v2 6/7] x86/mm: handle foreign mappings in p2m_entry_modify

2019-02-11 Thread Roger Pau Monne
So that the specific handling can be removed from atomic_write_ept_entry and be shared with npt and shadow code. This commit also removes the check that prevent non-ept PVH dom0 from mapping foreign pages. Signed-off-by: Roger Pau Monné --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper