Re: [Xen-devel] [PATCH v2 4/4] AMD/IOMMU: Treat head/tail pointers as byte offsets

2020-02-11 Thread Jan Beulich
On 10.02.2020 18:33, Andrew Cooper wrote: > The MMIO registers as already byte offsets. Using them in this form removes > the need to shift their values for use. > > It is also inefficient to store both entries and alloc_size (which only differ > by entry_size). Rename alloc_size to size, and dr

[Xen-devel] [PATCH v2 4/4] AMD/IOMMU: Treat head/tail pointers as byte offsets

2020-02-10 Thread Andrew Cooper
The MMIO registers as already byte offsets. Using them in this form removes the need to shift their values for use. It is also inefficient to store both entries and alloc_size (which only differ by entry_size). Rename alloc_size to size, and drop entries entirely, which simplifies the allocation