Re: [Xen-devel] [PATCH v2 3/6] libxc: allow HVM guest to have modules

2018-06-26 Thread Wei Liu
On Mon, Jun 25, 2018 at 05:58:52PM +0200, Roger Pau Monné wrote: > On Mon, Jun 25, 2018 at 12:35:30PM +0100, Wei Liu wrote: > > Lift the loading code out of PVH specific branch. Take the chance to > > make the debug message more useful. > > Would be nice to mention that you also account for virt_b

Re: [Xen-devel] [PATCH v2 3/6] libxc: allow HVM guest to have modules

2018-06-25 Thread Roger Pau Monné
On Mon, Jun 25, 2018 at 12:35:30PM +0100, Wei Liu wrote: > Lift the loading code out of PVH specific branch. Take the chance to > make the debug message more useful. Would be nice to mention that you also account for virt_base being unset. > IPXE will be loaded as a module of Rombios. > > Signe

[Xen-devel] [PATCH v2 3/6] libxc: allow HVM guest to have modules

2018-06-25 Thread Wei Liu
Lift the loading code out of PVH specific branch. Take the chance to make the debug message more useful. IPXE will be loaded as a module of Rombios. Signed-off-by: Wei Liu --- Cc: Ian Jackson --- tools/libxc/xc_dom_x86.c | 32 ++-- 1 file changed, 18 insertions(+),