Re: [Xen-devel] [PATCH v2 3/4] x86/HVM: implement memory read caching

2018-09-20 Thread Wei Liu
On Thu, Sep 20, 2018 at 12:39:59AM -0600, Jan Beulich wrote: > >>> On 19.09.18 at 17:57, wrote: > > On Tue, Sep 11, 2018 at 07:15:19AM -0600, Jan Beulich wrote: > >> Emulation requiring device model assistance uses a form of instruction > >> re-execution, assuming that the second (and any further)

Re: [Xen-devel] [PATCH v2 3/4] x86/HVM: implement memory read caching

2018-09-19 Thread Jan Beulich
>>> On 19.09.18 at 17:57, wrote: > On Tue, Sep 11, 2018 at 07:15:19AM -0600, Jan Beulich wrote: >> Emulation requiring device model assistance uses a form of instruction >> re-execution, assuming that the second (and any further) pass takes >> exactly the same path. This is a valid assumption as f

Re: [Xen-devel] [PATCH v2 3/4] x86/HVM: implement memory read caching

2018-09-19 Thread Wei Liu
On Tue, Sep 11, 2018 at 07:15:19AM -0600, Jan Beulich wrote: > Emulation requiring device model assistance uses a form of instruction > re-execution, assuming that the second (and any further) pass takes > exactly the same path. This is a valid assumption as far use of CPU > registers goes (as thos

Re: [Xen-devel] [PATCH v2 3/4] x86/HVM: implement memory read caching

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 09:38 > To: Paul Durrant > Cc: Andrew Cooper ; George Dunlap > ; Wei Liu ; xen-devel > > Subject: RE: [PATCH v2 3/4] x86/HVM: implement memory read caching > > >>> On 11.09.18 at 18:20, wrote:

Re: [Xen-devel] [PATCH v2 3/4] x86/HVM: implement memory read caching

2018-09-12 Thread Jan Beulich
>>> On 11.09.18 at 18:20, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 11 September 2018 14:15 >> >> @@ -2664,9 +2685,35 @@ void hvm_dump_emulation_state(const char >> hvmemul_ctxt->insn_buf); >> } >> >> +struct hvmemul_cache *hvmemul_cache_init(unsigned int nents

Re: [Xen-devel] [PATCH v2 3/4] x86/HVM: implement memory read caching

2018-09-11 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 11 September 2018 14:15 > To: xen-devel > Cc: Andrew Cooper ; Paul Durrant > ; Wei Liu ; George Dunlap > > Subject: [PATCH v2 3/4] x86/HVM: implement memory read caching > > Emulation requiring device model assis

[Xen-devel] [PATCH v2 3/4] x86/HVM: implement memory read caching

2018-09-11 Thread Jan Beulich
Emulation requiring device model assistance uses a form of instruction re-execution, assuming that the second (and any further) pass takes exactly the same path. This is a valid assumption as far use of CPU registers goes (as those can't change without any other instruction executing in between), b