Re: [Xen-devel] [PATCH v2 21/23] x86: expose CONFIG_HVM

2018-09-03 Thread Jan Beulich
>>> On 31.08.18 at 22:09, wrote: > On 30/08/18 07:21, Jan Beulich wrote: >>> + >>> + If unsure, say Y. >>> + >>> >>> config SHADOW_PAGING >> No double blank lines please. >> >> My previously voiced reservations wrt the shim remain. I continue >> to di

Re: [Xen-devel] [PATCH v2 21/23] x86: expose CONFIG_HVM

2018-08-31 Thread Andrew Cooper
On 30/08/18 07:21, Jan Beulich wrote: >> + >> + If unsure, say Y. >> + >> >> config SHADOW_PAGING > No double blank lines please. > > My previously voiced reservations wrt the shim remain. I continue > to disagree with Andrew that the symbol needs to

Re: [Xen-devel] [PATCH v2 21/23] x86: expose CONFIG_HVM

2018-08-29 Thread Juergen Gross
On 30/08/18 08:21, Jan Beulich wrote: On 29.08.18 at 18:56, wrote: >> On 28/08/18 14:33, Jan Beulich wrote: >> On 28.08.18 at 14:14, wrote: On 28/08/18 12:50, Jan Beulich wrote: On 26.08.18 at 14:19, wrote: >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfi

Re: [Xen-devel] [PATCH v2 21/23] x86: expose CONFIG_HVM

2018-08-29 Thread Jan Beulich
>>> On 29.08.18 at 18:56, wrote: > On 28/08/18 14:33, Jan Beulich wrote: > On 28.08.18 at 14:14, wrote: >>> On 28/08/18 12:50, Jan Beulich wrote: >>> On 26.08.18 at 14:19, wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -60,6 +60,12 @@ config PV_LINEAR_P

Re: [Xen-devel] [PATCH v2 21/23] x86: expose CONFIG_HVM

2018-08-29 Thread Andrew Cooper
On 28/08/18 14:33, Jan Beulich wrote: On 28.08.18 at 14:14, wrote: >> On 28/08/18 12:50, Jan Beulich wrote: >> On 26.08.18 at 14:19, wrote: --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -60,6 +60,12 @@ config PV_LINEAR_PT config HVM def_bool

Re: [Xen-devel] [PATCH v2 21/23] x86: expose CONFIG_HVM

2018-08-28 Thread Jan Beulich
>>> On 28.08.18 at 14:14, wrote: > On 28/08/18 12:50, Jan Beulich wrote: > On 26.08.18 at 14:19, wrote: >>> --- a/xen/arch/x86/Kconfig >>> +++ b/xen/arch/x86/Kconfig >>> @@ -60,6 +60,12 @@ config PV_LINEAR_PT >>> >>> config HVM >>> def_bool y >>> + prompt "HVM / PVH support" >>> +

Re: [Xen-devel] [PATCH v2 21/23] x86: expose CONFIG_HVM

2018-08-28 Thread Andrew Cooper
On 28/08/18 12:50, Jan Beulich wrote: On 26.08.18 at 14:19, wrote: >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfig >> @@ -60,6 +60,12 @@ config PV_LINEAR_PT >> >> config HVM >> def_bool y >> +prompt "HVM / PVH support" >> +---help--- >> + Interfaces to support

Re: [Xen-devel] [PATCH v2 21/23] x86: expose CONFIG_HVM

2018-08-28 Thread Jan Beulich
>>> On 26.08.18 at 14:19, wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -60,6 +60,12 @@ config PV_LINEAR_PT > > config HVM > def_bool y > + prompt "HVM / PVH support" > + ---help--- > + Interfaces to support HVM and PVH guests. > + > + If unsure

[Xen-devel] [PATCH v2 21/23] x86: expose CONFIG_HVM

2018-08-26 Thread Wei Liu
Signed-off-by: Wei Liu --- v2: use tab to indent Haven't added a dependency on PV_SHIM_EXCLUSIVE because agreement is not yet reached. --- xen/arch/x86/Kconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 73ab8f8..11637e1 100644 ---