Re: [Xen-devel] [PATCH v2 2/2] ns16550: enable use of PCI MSI

2018-12-03 Thread Roger Pau Monné
On Mon, Dec 03, 2018 at 01:40:06AM -0700, Jan Beulich wrote: > >>> On 30.11.18 at 17:33, wrote: > > On Mon, Oct 01, 2018 at 10:26:05AM -0600, Jan Beulich wrote: > >> --- a/xen/arch/x86/msi.c > >> +++ b/xen/arch/x86/msi.c > >> @@ -742,6 +742,16 @@ static int msi_capability_init(struct pc > >> > >

Re: [Xen-devel] [PATCH v2 2/2] ns16550: enable use of PCI MSI

2018-12-03 Thread Jan Beulich
>>> On 30.11.18 at 17:33, wrote: > On Mon, Oct 01, 2018 at 10:26:05AM -0600, Jan Beulich wrote: >> --- a/xen/arch/x86/msi.c >> +++ b/xen/arch/x86/msi.c >> @@ -742,6 +742,16 @@ static int msi_capability_init(struct pc >> >> *desc = entry; >> /* Restore the original MSI enabled bits */

Re: [Xen-devel] [PATCH v2 2/2] ns16550: enable use of PCI MSI

2018-12-03 Thread Jan Beulich
>>> On 30.11.18 at 13:40, wrote: > On Fri, Nov 30, 2018 at 01:52:39AM -0700, Jan Beulich wrote: >> >>> On 29.11.18 at 18:33, wrote: >> > On Mon, Oct 01, 2018 at 10:26:05AM -0600, Jan Beulich wrote: >> >> --- a/xen/arch/x86/msi.c >> >> +++ b/xen/arch/x86/msi.c >> >> @@ -742,6 +742,16 @@ static int

Re: [Xen-devel] [PATCH v2 2/2] ns16550: enable use of PCI MSI

2018-11-30 Thread Roger Pau Monné
On Mon, Oct 01, 2018 at 10:26:05AM -0600, Jan Beulich wrote: > Which, on x86, requires fiddling with the INTx bit in PCI config space, > since for internally used MSI we can't delegate this to Dom0. > > ns16550_init_postirq() also needs (benign) re-ordering of its > operations. > > Signed-off-by:

Re: [Xen-devel] [PATCH v2 2/2] ns16550: enable use of PCI MSI

2018-11-30 Thread Roger Pau Monné
On Fri, Nov 30, 2018 at 01:52:39AM -0700, Jan Beulich wrote: > >>> On 29.11.18 at 18:33, wrote: > > On Mon, Oct 01, 2018 at 10:26:05AM -0600, Jan Beulich wrote: > >> --- a/xen/arch/x86/msi.c > >> +++ b/xen/arch/x86/msi.c > >> @@ -742,6 +742,16 @@ static int msi_capability_init(struct pc > >> > >

Re: [Xen-devel] [PATCH v2 2/2] ns16550: enable use of PCI MSI

2018-11-30 Thread Jan Beulich
>>> On 29.11.18 at 18:33, wrote: > On Mon, Oct 01, 2018 at 10:26:05AM -0600, Jan Beulich wrote: >> --- a/xen/arch/x86/msi.c >> +++ b/xen/arch/x86/msi.c >> @@ -742,6 +742,16 @@ static int msi_capability_init(struct pc >> >> *desc = entry; >> /* Restore the original MSI enabled bits */

Re: [Xen-devel] [PATCH v2 2/2] ns16550: enable use of PCI MSI

2018-11-29 Thread Roger Pau Monné
On Mon, Oct 01, 2018 at 10:26:05AM -0600, Jan Beulich wrote: > Which, on x86, requires fiddling with the INTx bit in PCI config space, > since for internally used MSI we can't delegate this to Dom0. > > ns16550_init_postirq() also needs (benign) re-ordering of its > operations. > > Signed-off-by:

[Xen-devel] [PATCH v2 2/2] ns16550: enable use of PCI MSI

2018-10-01 Thread Jan Beulich
Which, on x86, requires fiddling with the INTx bit in PCI config space, since for internally used MSI we can't delegate this to Dom0. ns16550_init_postirq() also needs (benign) re-ordering of its operations. Signed-off-by: Jan Beulich --- v2: Re-base. --- a/docs/misc/xen-command-line.markdown +