Re: [Xen-devel] [PATCH v2 18/21] xen/arm: Allow vpl011 to be used by DomU

2018-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2018, Julien Grall wrote: > Hi Stefano, > > On 27/07/18 01:10, Stefano Stabellini wrote: > > On Tue, 24 Jul 2018, Julien Grall wrote: > > > On 07/07/18 00:12, Stefano Stabellini wrote: > > > > +VPL011_UNLOCK(d, flags); > > > > +} > > > > + > > > > +static void vpl011_write_data_

Re: [Xen-devel] [PATCH v2 18/21] xen/arm: Allow vpl011 to be used by DomU

2018-07-27 Thread Julien Grall
Hi Stefano, On 27/07/18 01:10, Stefano Stabellini wrote: On Tue, 24 Jul 2018, Julien Grall wrote: On 07/07/18 00:12, Stefano Stabellini wrote: +VPL011_UNLOCK(d, flags); +} + +static void vpl011_write_data_noring(struct domain *d, uint8_t data) +{ +unsigned long flags; +struct vpl01

Re: [Xen-devel] [PATCH v2 18/21] xen/arm: Allow vpl011 to be used by DomU

2018-07-26 Thread Stefano Stabellini
Thank you Julien. I addressed almost all comments. I had a problem with the implementation of buffering the chars, and I have an alternative comment on the function sharing. See below. On Tue, 24 Jul 2018, Julien Grall wrote: > Hi Stefano, > > On 07/07/18 00:12, Stefano Stabellini wrote: > > Mak

Re: [Xen-devel] [PATCH v2 18/21] xen/arm: Allow vpl011 to be used by DomU

2018-07-24 Thread Julien Grall
Hi Stefano, On 07/07/18 00:12, Stefano Stabellini wrote: Make vpl011 being able to be used without a userspace component in Dom0. In that case, output is printed to the Xen serial and input is received from the Xen serial one character at a time. Call domain_vpl011_init during construct_domU if

[Xen-devel] [PATCH v2 18/21] xen/arm: Allow vpl011 to be used by DomU

2018-07-06 Thread Stefano Stabellini
Make vpl011 being able to be used without a userspace component in Dom0. In that case, output is printed to the Xen serial and input is received from the Xen serial one character at a time. Call domain_vpl011_init during construct_domU if vpl011 is enabled. Introduce a new ring struct with only t