Re: [Xen-devel] [PATCH v2 04/10] AMD/IOMMU: use bit field for IRTE

2019-07-02 Thread Jan Beulich
On 02.07.2019 14:33, Andrew Cooper wrote: > On 27/06/2019 16:20, Jan Beulich wrote: >> At the same time restrict its scope to just the single source file >> actually using it, and abstract accesses by introducing a union of >> pointers. (A union of the actual table entries is not used to make it >>

Re: [Xen-devel] [PATCH v2 04/10] AMD/IOMMU: use bit field for IRTE

2019-07-02 Thread Andrew Cooper
On 27/06/2019 16:20, Jan Beulich wrote: > At the same time restrict its scope to just the single source file > actually using it, and abstract accesses by introducing a union of > pointers. (A union of the actual table entries is not used to make it > impossible to [wrongly, once the 128-bit form g

[Xen-devel] [PATCH v2 04/10] AMD/IOMMU: use bit field for IRTE

2019-06-27 Thread Jan Beulich
At the same time restrict its scope to just the single source file actually using it, and abstract accesses by introducing a union of pointers. (A union of the actual table entries is not used to make it impossible to [wrongly, once the 128-bit form gets added] perform pointer arithmetic / array ac