Re: [Xen-devel] [PATCH v2 02/12] pci: introduce a pci_sbdf_t field to pci_dev

2019-06-06 Thread Jan Beulich
>>> On 06.06.19 at 16:54, wrote: > On Thu, Jun 06, 2019 at 06:37:04AM -0600, Jan Beulich wrote: >> >>> On 06.06.19 at 11:01, wrote: >> > --- a/xen/include/xen/pci.h >> > +++ b/xen/include/xen/pci.h >> > @@ -83,9 +83,15 @@ struct pci_dev { >> > struct arch_msix *msix; >> > >> > struct

Re: [Xen-devel] [PATCH v2 02/12] pci: introduce a pci_sbdf_t field to pci_dev

2019-06-06 Thread Roger Pau Monné
On Thu, Jun 06, 2019 at 06:37:04AM -0600, Jan Beulich wrote: > >>> On 06.06.19 at 11:01, wrote: > > And use an union with the current seg, bus and devfn fields to make > > fields point to the same underlying data. > > > > No functional change. > > > > Suggested-by: Jan Beulich > > Signed-off-by

Re: [Xen-devel] [PATCH v2 02/12] pci: introduce a pci_sbdf_t field to pci_dev

2019-06-06 Thread Jan Beulich
>>> On 06.06.19 at 11:01, wrote: > And use an union with the current seg, bus and devfn fields to make > fields point to the same underlying data. > > No functional change. > > Suggested-by: Jan Beulich > Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich with one question: > --- a/xen/in

Re: [Xen-devel] [PATCH v2 02/12] pci: introduce a pci_sbdf_t field to pci_dev

2019-06-06 Thread Paul Durrant
Andrew > Cooper > ; Ian Jackson ; Tim > (Xen.org) ; Julien > Grall ; Jan Beulich ; Roger Pau > Monne > Subject: [Xen-devel] [PATCH v2 02/12] pci: introduce a pci_sbdf_t field to > pci_dev > > And use an union with the current seg, bus and devfn fields to make

[Xen-devel] [PATCH v2 02/12] pci: introduce a pci_sbdf_t field to pci_dev

2019-06-06 Thread Roger Pau Monne
And use an union with the current seg, bus and devfn fields to make fields point to the same underlying data. No functional change. Suggested-by: Jan Beulich Signed-off-by: Roger Pau Monné --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Julien Grall Cc: Konrad R