Re: [Xen-devel] [PATCH v2 01/13] x86/msr: Drop stale comment for vcpu_msrs.spec_ctrl

2018-07-16 Thread Andrew Cooper
On 16/07/18 10:37, Roger Pau Monné wrote: > On Fri, Jul 13, 2018 at 09:03:02PM +0100, Andrew Cooper wrote: >> More than the bottom two bits are now defined, and the MSR policy work has >> shown that using non-architectural representations turns out to be >> problematic >> for more than just asm co

Re: [Xen-devel] [PATCH v2 01/13] x86/msr: Drop stale comment for vcpu_msrs.spec_ctrl

2018-07-16 Thread Roger Pau Monné
On Fri, Jul 13, 2018 at 09:03:02PM +0100, Andrew Cooper wrote: > More than the bottom two bits are now defined, and the MSR policy work has > shown that using non-architectural representations turns out to be problematic > for more than just asm code. As the architectural representation is the > e

Re: [Xen-devel] [PATCH v2 01/13] x86/msr: Drop stale comment for vcpu_msrs.spec_ctrl

2018-07-16 Thread Jan Beulich
>>> On 13.07.18 at 22:03, wrote: > More than the bottom two bits are now defined, and the MSR policy work has > shown that using non-architectural representations turns out to be > problematic > for more than just asm code. As the architectural representation is the > expected default, we don't

[Xen-devel] [PATCH v2 01/13] x86/msr: Drop stale comment for vcpu_msrs.spec_ctrl

2018-07-13 Thread Andrew Cooper
More than the bottom two bits are now defined, and the MSR policy work has shown that using non-architectural representations turns out to be problematic for more than just asm code. As the architectural representation is the expected default, we don't need to justify why we are using it. Signed-