> -Original Message-
> From: Jan Beulich
> Sent: 21 June 2019 16:21
> To: Paul Durrant
> Cc: aisa...@bitdefender.com; Andrew Cooper ; Roger
> Pau Monne
> ; xen-devel ; WeiLiu
>
> Subject: RE: [Xen-devel] [PATCH v2] viridian: unify time sources
>
>
>>> On 21.06.19 at 15:58, wrote:
>> -Original Message-
>> From: Alexandru Stefan ISAILA
>> Sent: 21 June 2019 14:49
>> To: Paul Durrant ; xen-devel@lists.xenproject.org
>> Cc: Andrew Cooper ; Wei Liu ; Jan
>> Beulich
> ;
>>
>>> On 17.06.19 at 10:23, wrote:
> Currently, the time_ref_count enlightened time source maintains an offset
> such that time is frozen when the domain paused, but the reference_tsc
> enlightened time source does not. After migrate, the reference_tsc source
> may become invalidated (e.g. because o
> -Original Message-
> From: Alexandru Stefan ISAILA
> Sent: 21 June 2019 14:49
> To: Paul Durrant ; xen-devel@lists.xenproject.org
> Cc: Andrew Cooper ; Wei Liu ; Jan
> Beulich ;
> Roger Pau Monne
> Subject: Re: [Xen-devel] [PATCH v2] viri
> /*
> @@ -136,7 +100,7 @@ static int64_t time_ref_count(const struct domain *d)
>* 128 bit number which is then shifted 64 times to the right to obtain
>* the high 64 bits."
>*/
Is there a good reason for using signed offset here? If so then maybe
you should change the return type
Ping?
> -Original Message-
> From: Paul Durrant
> Sent: 17 June 2019 09:24
> To: xen-devel@lists.xenproject.org
> Cc: Paul Durrant ; Jan Beulich ;
> Andrew Cooper
> ; Wei Liu ; Roger Pau Monne
>
> Subject: [PATCH v2] viridian: unify time sources
>
> Currently, the time_ref_count enlig
Currently, the time_ref_count enlightened time source maintains an offset
such that time is frozen when the domain paused, but the reference_tsc
enlightened time source does not. After migrate, the reference_tsc source
may become invalidated (e.g. because of host cpu frequency mismatch) which
will
