Re: [Xen-devel] [PATCH v2] libxl: wait for the ack when issuing power control requests

2019-10-02 Thread Wei Liu
On Tue, Oct 01, 2019 at 05:27:53PM +0200, Roger Pau Monné wrote: > On Tue, Oct 01, 2019 at 05:22:33PM +0200, Roger Pau Monne wrote: > > +int libxl_domain_reboot(libxl_ctx *ctx, uint32_t domid, > > +const libxl_asyncop_how *ao_how) > > { > > -GC_INIT(ctx); > > +AO_CR

Re: [Xen-devel] [PATCH v2] libxl: wait for the ack when issuing power control requests

2019-10-02 Thread Christian Lindig
> On 1 Oct 2019, at 16:22, Roger Pau Monne wrote: > > tools/ocaml/libs/xl/xenlight.ml.in | 4 +- > tools/ocaml/libs/xl/xenlight.mli.in | 4 +- > tools/ocaml/libs/xl/xenlight_stubs.c | 18 -- Acked-by: Christian Lindig ___ Xen-devel mailing li

Re: [Xen-devel] [PATCH v2] libxl: wait for the ack when issuing power control requests

2019-10-02 Thread Jürgen Groß
On 02.10.19 12:08, Roger Pau Monné wrote: Adding Juergen for a release-ack. On Tue, Oct 01, 2019 at 05:44:07PM +0100, Anthony PERARD wrote: On Tue, Oct 01, 2019 at 05:22:33PM +0200, Roger Pau Monne wrote: Currently only suspend power control requests wait for an ack from the domain, while pow

Re: [Xen-devel] [PATCH v2] libxl: wait for the ack when issuing power control requests

2019-10-02 Thread Roger Pau Monné
Adding Juergen for a release-ack. On Tue, Oct 01, 2019 at 05:44:07PM +0100, Anthony PERARD wrote: > On Tue, Oct 01, 2019 at 05:22:33PM +0200, Roger Pau Monne wrote: > > Currently only suspend power control requests wait for an ack from the > > domain, while power off or reboot requests simply writ

Re: [Xen-devel] [PATCH v2] libxl: wait for the ack when issuing power control requests

2019-10-01 Thread Anthony PERARD
On Tue, Oct 01, 2019 at 05:22:33PM +0200, Roger Pau Monne wrote: > Currently only suspend power control requests wait for an ack from the > domain, while power off or reboot requests simply write the command to > xenstore and exit. > > Introduce a 1 minute wait for the domain to acknowledge the re

Re: [Xen-devel] [PATCH v2] libxl: wait for the ack when issuing power control requests

2019-10-01 Thread Roger Pau Monné
On Tue, Oct 01, 2019 at 05:22:33PM +0200, Roger Pau Monne wrote: > +int libxl_domain_reboot(libxl_ctx *ctx, uint32_t domid, > +const libxl_asyncop_how *ao_how) > { > -GC_INIT(ctx); > +AO_CREATE(ctx, domid, ao_how); > +libxl__xswait_state *pvcontrol; > int r

[Xen-devel] [PATCH v2] libxl: wait for the ack when issuing power control requests

2019-10-01 Thread Roger Pau Monne
Currently only suspend power control requests wait for an ack from the domain, while power off or reboot requests simply write the command to xenstore and exit. Introduce a 1 minute wait for the domain to acknowledge the request, or else return an error. The suspend code is slightly modified to us