Re: [Xen-devel] [PATCH v10 5/6] xen/common: use DEFINE_SYMBOL as required

2019-02-27 Thread Jan Beulich
>>> On 26.02.19 at 22:14, wrote: > On Tue, 26 Feb 2019, Jan Beulich wrote: >> >>> On 25.02.19 at 21:50, wrote: >> > --- a/xen/common/lib.c >> > +++ b/xen/common/lib.c >> > @@ -492,12 +492,15 @@ unsigned long long parse_size_and_unit(const char >> > *s, >> > const char **ps) >> > } >> > >> >

Re: [Xen-devel] [PATCH v10 5/6] xen/common: use DEFINE_SYMBOL as required

2019-02-26 Thread Stefano Stabellini
On Tue, 26 Feb 2019, Jan Beulich wrote: > >>> On 25.02.19 at 21:50, wrote: > > --- a/xen/common/kernel.c > > +++ b/xen/common/kernel.c > > @@ -306,20 +306,28 @@ void add_taint(unsigned int flag) > > tainted |= flag; > > } > > > > +/* > > + * We cannot use DEFINE_SYMBOL because we have thre

Re: [Xen-devel] [PATCH v10 5/6] xen/common: use DEFINE_SYMBOL as required

2019-02-26 Thread Jan Beulich
>>> On 25.02.19 at 21:50, wrote: > --- a/xen/common/kernel.c > +++ b/xen/common/kernel.c > @@ -306,20 +306,28 @@ void add_taint(unsigned int flag) > tainted |= flag; > } > > +/* > + * We cannot use DEFINE_SYMBOL because we have three variables instead > + * of two > + */ > extern const in

[Xen-devel] [PATCH v10 5/6] xen/common: use DEFINE_SYMBOL as required

2019-02-25 Thread Stefano Stabellini
Use DEFINE_SYMBOL and the two static inline functions that come with it for comparisons and subtractions of: __note_gnu_build_id_start, __note_gnu_build_id_end, __lock_profile_start, __lock_profile_end, __initcall_start, __initcall_end, __presmp_initcall_end, __ctors_start, __ctors_end, __end_sche