Re: [Xen-devel] [PATCH v10 4/6] xen/x86: use DEFINE_SYMBOL as required

2019-02-27 Thread Jan Beulich
>>> On 26.02.19 at 20:23, wrote: > On Tue, 26 Feb 2019, Ian Jackson wrote: >> Stefano Stabellini writes ("[PATCH v10 4/6] xen/x86: use DEFINE_SYMBOL as >> required"): >> > Use SYMBOLS_SUBTRACT and SYMBOLS_COMPARE in cases of comparisons and >> > subtractions of: >> ... >> > Use explicit casts to

Re: [Xen-devel] [PATCH v10 4/6] xen/x86: use DEFINE_SYMBOL as required

2019-02-26 Thread Stefano Stabellini
On Tue, 26 Feb 2019, Ian Jackson wrote: > Stefano Stabellini writes ("[PATCH v10 4/6] xen/x86: use DEFINE_SYMBOL as > required"): > > Use SYMBOLS_SUBTRACT and SYMBOLS_COMPARE in cases of comparisons and > > subtractions of: > ... > > Use explicit casts to uintptr_t when it is not possible to use t

Re: [Xen-devel] [PATCH v10 4/6] xen/x86: use DEFINE_SYMBOL as required

2019-02-26 Thread Ian Jackson
Stefano Stabellini writes ("[PATCH v10 4/6] xen/x86: use DEFINE_SYMBOL as required"): > Use SYMBOLS_SUBTRACT and SYMBOLS_COMPARE in cases of comparisons and > subtractions of: Oh and the commit message still mentions old macro names :-). FTR I think your definition macro should be called SYMBOL

Re: [Xen-devel] [PATCH v10 4/6] xen/x86: use DEFINE_SYMBOL as required

2019-02-26 Thread Ian Jackson
Stefano Stabellini writes ("[PATCH v10 4/6] xen/x86: use DEFINE_SYMBOL as required"): > Use SYMBOLS_SUBTRACT and SYMBOLS_COMPARE in cases of comparisons and > subtractions of: ... > Use explicit casts to uintptr_t when it is not possible to use the > provided static inline functions. Why is it no

[Xen-devel] [PATCH v10 4/6] xen/x86: use DEFINE_SYMBOL as required

2019-02-25 Thread Stefano Stabellini
Use SYMBOLS_SUBTRACT and SYMBOLS_COMPARE in cases of comparisons and subtractions of: __2M_rwdata_start, __2M_rwdata_end, __end_vpci_array, __start_vpci_array, _stextentry, _etextentry, __trampoline_rel_start, __trampoline_rel_stop, __trampoline_seg_start, __trampoline_seg_stop __per_cpu_start, __