Re: [Xen-devel] [PATCH v10 3/6] xen/arm: use DEFINE_SYMBOL as required

2019-02-28 Thread Stefano Stabellini
On Wed, 27 Feb 2019, Jan Beulich wrote: > >>> On 26.02.19 at 20:20, wrote: > > On Tue, 26 Feb 2019, Ian Jackson wrote: > >> Having written all that down (what a palaver), we can see that your > >> cast, above, is a breach of the rules. Instead you can just pass the > >> struct abstract_alt_instr*

Re: [Xen-devel] [PATCH v10 3/6] xen/arm: use DEFINE_SYMBOL as required

2019-02-27 Thread Jan Beulich
>>> On 26.02.19 at 20:20, wrote: > On Tue, 26 Feb 2019, Ian Jackson wrote: >> Having written all that down (what a palaver), we can see that your >> cast, above, is a breach of the rules. Instead you can just pass the >> struct abstract_alt_instr*, and all is well. Then you don't need a >> comme

Re: [Xen-devel] [PATCH v10 3/6] xen/arm: use DEFINE_SYMBOL as required

2019-02-26 Thread Stefano Stabellini
On Tue, 26 Feb 2019, Ian Jackson wrote: > Having written all that down (what a palaver), we can see that your > cast, above, is a breach of the rules. Instead you can just pass the > struct abstract_alt_instr*, and all is well. Then you don't need a > comment at the use site, either, since you ar

Re: [Xen-devel] [PATCH v10 3/6] xen/arm: use DEFINE_SYMBOL as required

2019-02-26 Thread Ian Jackson
Stefano Stabellini writes ("[PATCH v10 3/6] xen/arm: use DEFINE_SYMBOL as required"): > Use DEFINE_SYMBOL and the two static inline functions that come with it > for comparisons and subtractions of: > > __init_begin, __init_end, __alt_instructions, __alt_instructions_end, > __per_cpu_start, __per

[Xen-devel] [PATCH v10 3/6] xen/arm: use DEFINE_SYMBOL as required

2019-02-25 Thread Stefano Stabellini
Use DEFINE_SYMBOL and the two static inline functions that come with it for comparisons and subtractions of: __init_begin, __init_end, __alt_instructions, __alt_instructions_end, __per_cpu_start, __per_cpu_data_end, _splatform, _eplatform, _sdevice, _edevice, _asdevice, _aedevice. Use explicit ca