Re: [Xen-devel] [PATCH v1] restore the fake x2apic value for cpuid

2018-12-03 Thread Juergen Gross
On 03/12/2018 12:15, Xin Li (Talons) wrote: > Hi Juergen, > thanks for your comments. > >Are you suggesting to call apic_is_x2apic_enabled() in __x2apic_disable()? >but I think that's exact what changed due to the fake xen_cpuid value. >Doing so will probably still see the EXTD bit

Re: [Xen-devel] [PATCH v1] restore the fake x2apic value for cpuid

2018-12-03 Thread Xin Li (Talons)
in Li (Talons); Sergey Dyasli; Andrew Cooper; Igor Druzhinin Subject: Re: [Xen-devel] [PATCH v1] restore the fake x2apic value for cpuid On 03/12/2018 08:00, Juergen Gross wrote: > On 22/11/2018 08:18, Xin Li wrote: >> From: Talons Lee >> >> Commit e657fcc clears cpu x2apic capab

Re: [Xen-devel] [PATCH v1] restore the fake x2apic value for cpuid

2018-12-02 Thread Juergen Gross
On 03/12/2018 08:00, Juergen Gross wrote: > On 22/11/2018 08:18, Xin Li wrote: >> From: Talons Lee >> >> Commit e657fcc clears cpu x2apic capability bit instead of using fake >> cpuid value. However, with cpuid x2apic bit on, xen_read_msr_safe() will >> not clear the EXTD bit, which leads to unces

Re: [Xen-devel] [PATCH v1] restore the fake x2apic value for cpuid

2018-12-02 Thread Juergen Gross
On 22/11/2018 08:18, Xin Li wrote: > From: Talons Lee > > Commit e657fcc clears cpu x2apic capability bit instead of using fake > cpuid value. However, with cpuid x2apic bit on, xen_read_msr_safe() will > not clear the EXTD bit, which leads to uncessary msr write trying to > disable x2apic in __x

[Xen-devel] [PATCH v1] restore the fake x2apic value for cpuid

2018-11-21 Thread Xin Li
From: Talons Lee Commit e657fcc clears cpu x2apic capability bit instead of using fake cpuid value. However, with cpuid x2apic bit on, xen_read_msr_safe() will not clear the EXTD bit, which leads to uncessary msr write trying to disable x2apic in __x2apic_disable(). So restore the fake x2apic val