Re: [Xen-devel] [PATCH v1] pv_console: remove unnecessary #ifdefs

2018-03-06 Thread Wei Liu
On Tue, Mar 06, 2018 at 08:51:56AM +, Sergey Dyasli wrote: > The header for PV console contains empty function definitions in case of > !CONFIG_XEN_GUEST specially to avoid #ifdefs in a code that uses them > to make the code look cleaner. > > Unfortunately, during the release of shim-comet, PV

Re: [Xen-devel] [PATCH v1] pv_console: remove unnecessary #ifdefs

2018-03-06 Thread Jan Beulich
>>> On 06.03.18 at 09:51, wrote: > The header for PV console contains empty function definitions in case of > !CONFIG_XEN_GUEST specially to avoid #ifdefs in a code that uses them > to make the code look cleaner. > > Unfortunately, during the release of shim-comet, PV console functions > were enc

[Xen-devel] [PATCH v1] pv_console: remove unnecessary #ifdefs

2018-03-06 Thread Sergey Dyasli
The header for PV console contains empty function definitions in case of !CONFIG_XEN_GUEST specially to avoid #ifdefs in a code that uses them to make the code look cleaner. Unfortunately, during the release of shim-comet, PV console functions were enclosed into unnecessary #ifdefs CONFIG_X86. Rem