Re: [Xen-devel] [PATCH v1] hvm/svm: Implement Debug events

2018-03-19 Thread Alexandru Stefan ISAILA
On Lu, 2018-03-19 at 14:22 +, Andrew Cooper wrote: > On 19/03/18 14:07, Alexandru Isaila wrote: > > > > -case VMEXIT_EXCEPTION_BP: > > -inst_len = __get_instruction_length(v, INSTR_INT3); > > +case VMEXIT_EXCEPTION_BP:; > > +inst_len = vmcb->nextrip - vmcb->rip; > Sorry

Re: [Xen-devel] [PATCH v1] hvm/svm: Implement Debug events

2018-03-19 Thread Razvan Cojocaru
On 03/19/2018 04:48 PM, Tamas K Lengyel wrote: > On Mon, Mar 19, 2018 at 8:07 AM, Alexandru Isaila > wrote: >> At this moment the Debug events for the AMD architecture are not >> forwarded to the monitor layer. >> >> This patch adds the Debug event to the common capabilities, adds >> the VMEXIT_IC

Re: [Xen-devel] [PATCH v1] hvm/svm: Implement Debug events

2018-03-19 Thread Tamas K Lengyel
On Mon, Mar 19, 2018 at 8:07 AM, Alexandru Isaila wrote: > At this moment the Debug events for the AMD architecture are not > forwarded to the monitor layer. > > This patch adds the Debug event to the common capabilities, adds > the VMEXIT_ICEBP then forwards the event to the monitor layer. > > Ch

Re: [Xen-devel] [PATCH v1] hvm/svm: Implement Debug events

2018-03-19 Thread Andrew Cooper
On 19/03/18 14:07, Alexandru Isaila wrote: > -case VMEXIT_EXCEPTION_BP: > -inst_len = __get_instruction_length(v, INSTR_INT3); > +case VMEXIT_EXCEPTION_BP:; > +inst_len = vmcb->nextrip - vmcb->rip; Sorry, but no.  This will break on older AMD hardware.  You must retain the

[Xen-devel] [PATCH v1] hvm/svm: Implement Debug events

2018-03-19 Thread Alexandru Isaila
At this moment the Debug events for the AMD architecture are not forwarded to the monitor layer. This patch adds the Debug event to the common capabilities, adds the VMEXIT_ICEBP then forwards the event to the monitor layer. Chapter 2: SVM Processor and Platform Extensions: "Note: A vector 1 exce