Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-27 Thread Razvan Cojocaru
On 02/27/2018 06:26 PM, George Dunlap wrote: >>> As an aside -- are you sure clearing the NOFLUSH from reported CR3 >>> values during introspection is the right thing to do? You don't think >>> your introspection engine will ever want to know if the guest OS is >>> setting this bit? >> >> We can't

Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-27 Thread George Dunlap
On 02/27/2018 04:19 PM, Razvan Cojocaru wrote: > On 02/27/2018 05:53 PM, George Dunlap wrote: >> On 02/23/2018 07:29 AM, Razvan Cojocaru wrote: >>> On 02/23/2018 06:53 AM, Tian, Kevin wrote: > From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com] > Sent: Friday, February 16, 2018 6:22 PM

Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-27 Thread Razvan Cojocaru
On 02/27/2018 05:53 PM, George Dunlap wrote: > On 02/23/2018 07:29 AM, Razvan Cojocaru wrote: >> On 02/23/2018 06:53 AM, Tian, Kevin wrote: From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com] Sent: Friday, February 16, 2018 6:22 PM The emulation layers of Xen lack PCID supp

Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-27 Thread George Dunlap
On 02/23/2018 07:29 AM, Razvan Cojocaru wrote: > On 02/23/2018 06:53 AM, Tian, Kevin wrote: >>> From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com] >>> Sent: Friday, February 16, 2018 6:22 PM >>> >>> The emulation layers of Xen lack PCID support, and as we only offer >>> PCID to HAP guests, al

Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-23 Thread Tian, Kevin
> From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com] > Sent: Friday, February 23, 2018 3:32 PM > > On 02/23/2018 09:29 AM, Razvan Cojocaru wrote: > > Lacking PCID support in the emulation layer creates two different way of > > handling the NOFLUSH being set: one is in hardware, and this happ

Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-22 Thread Razvan Cojocaru
On 02/23/2018 09:29 AM, Razvan Cojocaru wrote: > Lacking PCID support in the emulation layer creates two different way of > handling the NOFLUSH being set: one is in hardware, and this happens for > everything except the introspection case, and one in the emulation layer > (this happens when an int

Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-22 Thread Razvan Cojocaru
On 02/23/2018 06:53 AM, Tian, Kevin wrote: >> From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com] >> Sent: Friday, February 16, 2018 6:22 PM >> >> The emulation layers of Xen lack PCID support, and as we only offer >> PCID to HAP guests, all writes to CR3 are handled by hardware, >> except whe

Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-22 Thread Tian, Kevin
> From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com] > Sent: Friday, February 16, 2018 6:22 PM > > The emulation layers of Xen lack PCID support, and as we only offer > PCID to HAP guests, all writes to CR3 are handled by hardware, > except when introspection is involved. Consequently, tryin

Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-19 Thread Razvan Cojocaru
On 02/19/2018 10:53 AM, Jan Beulich wrote: On 19.02.18 at 09:48, wrote: >> On 02/16/2018 01:17 PM, Jan Beulich wrote: >> On 16.02.18 at 11:22, wrote: The emulation layers of Xen lack PCID support, and as we only offer PCID to HAP guests, all writes to CR3 are handled by hardwar

Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-19 Thread Jan Beulich
>>> On 19.02.18 at 09:48, wrote: > On 02/16/2018 01:17 PM, Jan Beulich wrote: > On 16.02.18 at 11:22, wrote: >>> The emulation layers of Xen lack PCID support, and as we only offer >>> PCID to HAP guests, all writes to CR3 are handled by hardware, >>> except when introspection is involved. Co

Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-19 Thread Razvan Cojocaru
On 02/16/2018 01:17 PM, Jan Beulich wrote: On 16.02.18 at 11:22, wrote: >> The emulation layers of Xen lack PCID support, and as we only offer >> PCID to HAP guests, all writes to CR3 are handled by hardware, >> except when introspection is involved. Consequently, trying to set >> CR3 when th

Re: [Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-16 Thread Jan Beulich
>>> On 16.02.18 at 11:22, wrote: > The emulation layers of Xen lack PCID support, and as we only offer > PCID to HAP guests, all writes to CR3 are handled by hardware, > except when introspection is involved. Consequently, trying to set > CR3 when the noflush bit is set in hvm_set_cr3() leads to d

[Xen-devel] [PATCH V5] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-16 Thread Razvan Cojocaru
The emulation layers of Xen lack PCID support, and as we only offer PCID to HAP guests, all writes to CR3 are handled by hardware, except when introspection is involved. Consequently, trying to set CR3 when the noflush bit is set in hvm_set_cr3() leads to domain crashes. The workaround is to clear