Re: [Xen-devel] [PATCH V4 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-20 Thread Oleksandr
Hi Julien + +int __init iommu_add_dt_device(struct dt_device_node *np) Sorry to only realise it now. Would it make sense to have this function implemented in xen/passthrough/device_tree.c? Not entirely sure. device_tree.c is a common code. The iommu_fwspec stuff (widely used in t

Re: [Xen-devel] [PATCH V4 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-20 Thread Julien Grall
On 19/09/2019 14:26, Oleksandr wrote: On 19.09.19 15:29, Julien Grall wrote: Hi, Hi, Julien Hi, + +int __init iommu_add_dt_device(struct dt_device_node *np) Sorry to only realise it now. Would it make sense to have this function implemented in xen/passthrough/device_tree.c? Not

Re: [Xen-devel] [PATCH V4 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-19 Thread Oleksandr
On 19.09.19 15:29, Julien Grall wrote: Hi, Hi, Julien + +int __init iommu_add_dt_device(struct dt_device_node *np) Sorry to only realise it now. Would it make sense to have this function implemented in xen/passthrough/device_tree.c? Not entirely sure. device_tree.c is a common code.

Re: [Xen-devel] [PATCH V4 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-19 Thread Julien Grall
Hi, On 19/09/2019 13:25, Oleksandr wrote: On 19.09.19 14:35, Julien Grall wrote: Hi Oleksandr, On 13/09/2019 16:35, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The main puprose of this patch is to add a way to register DT device (which is behind the IOMMU) using the generic IOMMU

Re: [Xen-devel] [PATCH V4 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-19 Thread Oleksandr
On 19.09.19 14:35, Julien Grall wrote: Hi Oleksandr, Hi, Julien. On 13/09/2019 16:35, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The main puprose of this patch is to add a way to register DT device (which is behind the IOMMU) using the generic IOMMU DT bindings [1] before as

Re: [Xen-devel] [PATCH V4 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-19 Thread Julien Grall
Hi Oleksandr, On 13/09/2019 16:35, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The main puprose of this patch is to add a way to register DT device (which is behind the IOMMU) using the generic IOMMU DT bindings [1] before assigning that device to a domain. So, this patch adds new

Re: [Xen-devel] [PATCH V4 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-16 Thread Oleksandr
On 16.09.19 12:53, Jan Beulich wrote: Hi, Jan On 13.09.2019 17:35, Oleksandr Tyshchenko wrote: --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -239,6 +239,16 @@ struct iommu_ops { int __must_check (*iotlb_flush_all)(struct domain *d); int (*get_reserved_device_memor

Re: [Xen-devel] [PATCH V4 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-16 Thread Jan Beulich
On 13.09.2019 17:35, Oleksandr Tyshchenko wrote: > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -239,6 +239,16 @@ struct iommu_ops { > int __must_check (*iotlb_flush_all)(struct domain *d); > int (*get_reserved_device_memory)(iommu_grdm_t *, void *); > void (*du

[Xen-devel] [PATCH V4 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-13 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko The main puprose of this patch is to add a way to register DT device (which is behind the IOMMU) using the generic IOMMU DT bindings [1] before assigning that device to a domain. So, this patch adds new "iommu_add_dt_device" API for adding DT device to the IOMMU using