Re: [Xen-devel] [PATCH 9/9] x86: PCID is unused when !PV

2019-09-12 Thread Roger Pau Monné
On Thu, Sep 12, 2019 at 05:48:16PM +0200, Jan Beulich wrote: > On 12.09.2019 17:31, Roger Pau Monné wrote: > > On Wed, Sep 11, 2019 at 05:26:46PM +0200, Jan Beulich wrote: > >> @@ -301,8 +305,12 @@ static inline void write_cr4(unsigned lo > >> { > >> struct cpu_info *info = get_cpu_info(); >

Re: [Xen-devel] [PATCH 9/9] x86: PCID is unused when !PV

2019-09-12 Thread Jan Beulich
On 12.09.2019 17:31, Roger Pau Monné wrote: > On Wed, Sep 11, 2019 at 05:26:46PM +0200, Jan Beulich wrote: >> @@ -301,8 +305,12 @@ static inline void write_cr4(unsigned lo >> { >> struct cpu_info *info = get_cpu_info(); >> >> +#ifdef CONFIG_PV >> /* No global pages in case of PCIDs en

Re: [Xen-devel] [PATCH 9/9] x86: PCID is unused when !PV

2019-09-12 Thread Jan Beulich
On 12.09.2019 17:31, Roger Pau Monné wrote: > On Wed, Sep 11, 2019 at 05:26:46PM +0200, Jan Beulich wrote: >> This allows in particular some streamlining of the TLB flushing code >> paths. >> >> Signed-off-by: Jan Beulich >> >> --- a/xen/arch/x86/flushtlb.c >> +++ b/xen/arch/x86/flushtlb.c >> @@

Re: [Xen-devel] [PATCH 9/9] x86: PCID is unused when !PV

2019-09-12 Thread Roger Pau Monné
On Wed, Sep 11, 2019 at 05:26:46PM +0200, Jan Beulich wrote: > This allows in particular some streamlining of the TLB flushing code > paths. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/flushtlb.c > +++ b/xen/arch/x86/flushtlb.c > @@ -24,6 +24,11 @@ > #define WRAP_MASK (0x03FFU) >

[Xen-devel] [PATCH 9/9] x86: PCID is unused when !PV

2019-09-11 Thread Jan Beulich
This allows in particular some streamlining of the TLB flushing code paths. Signed-off-by: Jan Beulich --- a/xen/arch/x86/flushtlb.c +++ b/xen/arch/x86/flushtlb.c @@ -24,6 +24,11 @@ #define WRAP_MASK (0x03FFU) #endif +#ifndef CONFIG_PV +# undef X86_CR4_PCIDE +# define X86_CR4_PCIDE 0 +#e

[Xen-devel] [PATCH 9/9] x86: PCID is unused when !PV

2019-05-02 Thread Jan Beulich
This allows in particular some streamlining of the TLB flushing code paths. Signed-off-by: Jan Beulich --- a/xen/arch/x86/flushtlb.c +++ b/xen/arch/x86/flushtlb.c @@ -24,6 +24,11 @@ #define WRAP_MASK (0x03FFU) #endif +#ifndef CONFIG_PV +# undef X86_CR4_PCIDE +# define X86_CR4_PCIDE 0 +#e