Re: [Xen-devel] [PATCH 8/9] AMD/IOMMU: enable x2APIC mode when available

2019-06-18 Thread Jan Beulich
>>> On 18.06.19 at 15:40, wrote: > On 13/06/2019 14:27, Jan Beulich wrote: >> @@ -1346,7 +1399,7 @@ int __init amd_iommu_init(void) >> /* per iommu initialization */ >> for_each_amd_iommu ( iommu ) >> { >> -rc = amd_iommu_init_one(iommu); >> +rc = amd_iommu_init_one

Re: [Xen-devel] [PATCH 8/9] AMD/IOMMU: enable x2APIC mode when available

2019-06-18 Thread Andrew Cooper
On 13/06/2019 14:27, Jan Beulich wrote: > @@ -1346,7 +1399,7 @@ int __init amd_iommu_init(void) > /* per iommu initialization */ > for_each_amd_iommu ( iommu ) > { > -rc = amd_iommu_init_one(iommu); > +rc = amd_iommu_init_one(iommu, !xt); This logic is very subtle,

[Xen-devel] [PATCH 8/9] AMD/IOMMU: enable x2APIC mode when available

2019-06-13 Thread Jan Beulich
In order for the CPUs to use x2APIC mode, the IOMMU(s) first need to be switched into suitable state. The post-AP-bringup IRQ affinity adjustment is done also for the non- x2APIC case. Signed-off-by: Jan Beulich --- TBD: Instead of the system_state check in iov_enable_xt() the function coul