Re: [Xen-devel] [PATCH 6/7] x86/ucode/intel: Clean up microcode_sanity_check()

2020-03-26 Thread Jan Beulich
On 26.03.2020 15:41, Andrew Cooper wrote: > On 25/03/2020 14:07, Jan Beulich wrote: >>> Introduce a check missing from the old code, that total_size is a multiple >>> of >>> 1024 bytes, >> Where is this documented? The rather brief section in SDM vol 3 doesn't >> mention anything like this. > > I

Re: [Xen-devel] [PATCH 6/7] x86/ucode/intel: Clean up microcode_sanity_check()

2020-03-26 Thread Andrew Cooper
On 25/03/2020 14:07, Jan Beulich wrote: >> Introduce a check missing from the old code, that total_size is a multiple of >> 1024 bytes, > Where is this documented? The rather brief section in SDM vol 3 doesn't > mention anything like this. It is in the middle of the final paragraph of 9.11.1 Micro

Re: [Xen-devel] [PATCH 6/7] x86/ucode/intel: Clean up microcode_sanity_check()

2020-03-25 Thread Jan Beulich
On 23.03.2020 11:17, Andrew Cooper wrote: > Rewrite the size checks in a way which which doesn't depend on Xen being > compiled as 64bit. One too many "which"? > Introduce a check missing from the old code, that total_size is a multiple of > 1024 bytes, Where is this documented? The rather brief

[Xen-devel] [PATCH 6/7] x86/ucode/intel: Clean up microcode_sanity_check()

2020-03-23 Thread Andrew Cooper
Rewrite the size checks in a way which which doesn't depend on Xen being compiled as 64bit. Introduce a check missing from the old code, that total_size is a multiple of 1024 bytes, and drop unnecessarily defines/macros/structures. No practical change in behaviour. Signed-off-by: Andrew Cooper