Re: [Xen-devel] [PATCH 6/6] x86/boot: Drop INVALID_VCPU

2020-01-08 Thread Jan Beulich
On 07.01.2020 19:07, Andrew Cooper wrote: > On 07/01/2020 16:52, Jan Beulich wrote: >> On 06.01.2020 16:54, Andrew Cooper wrote: >>> --- a/xen/arch/x86/setup.c >>> +++ b/xen/arch/x86/setup.c >>> @@ -705,7 +705,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) >>> /* Critical region wi

Re: [Xen-devel] [PATCH 6/6] x86/boot: Drop INVALID_VCPU

2020-01-07 Thread Andrew Cooper
On 07/01/2020 16:52, Jan Beulich wrote: > On 06.01.2020 16:54, Andrew Cooper wrote: >> Now that NULL will fault at boot, there is no need for a special constant to >> signify "current not set up yet". > Mind making this "... no strong need ..."? The benefit of an easily > recognizable value goes aw

Re: [Xen-devel] [PATCH 6/6] x86/boot: Drop INVALID_VCPU

2020-01-07 Thread Jan Beulich
On 06.01.2020 16:54, Andrew Cooper wrote: > Now that NULL will fault at boot, there is no need for a special constant to > signify "current not set up yet". Mind making this "... no strong need ..."? The benefit of an easily recognizable value goes away, but I guess we'll be fine without. IOW I'm

[Xen-devel] [PATCH 6/6] x86/boot: Drop INVALID_VCPU

2020-01-06 Thread Andrew Cooper
Now that NULL will fault at boot, there is no need for a special constant to signify "current not set up yet". Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/arch/x86/cpu/mcheck/mce.c | 2 +- xen/arch/x86/domain_page.c| 2 +- xen/arch/x86/setup.c