Re: [Xen-devel] [PATCH 5/6] x86/mm: clean up SHARED_M2P{, _ENTRY} uses

2017-12-20 Thread Tim Deegan
At 08:08 -0700 on 12 Dec (1513066100), Jan Beulich wrote: > Stop open-coding SHARED_M2P() and drop a pointless use of it from > paging_mfn_is_dirty() (!VALID_M2P() is a superset of SHARED_M2P()) and > another one from free_page_type() (prior assertions render this > redundant). > > Signed-off-by:

Re: [Xen-devel] [PATCH 5/6] x86/mm: clean up SHARED_M2P{, _ENTRY} uses

2017-12-18 Thread Jan Beulich
>>> On 12.12.17 at 18:50, wrote: > On 12/12/2017 03:08 PM, Jan Beulich wrote: >> --- a/xen/arch/x86/mm.c >> +++ b/xen/arch/x86/mm.c >> @@ -2371,9 +2371,7 @@ int free_page_type(struct page_info *pag >> >> gmfn = mfn_to_gmfn(owner, mfn_x(page_to_mfn(page))); >> ASSERT(VALID_M2P(g

Re: [Xen-devel] [PATCH 5/6] x86/mm: clean up SHARED_M2P{, _ENTRY} uses

2017-12-13 Thread Jan Beulich
>>> On 12.12.17 at 18:50, wrote: > On 12/12/2017 03:08 PM, Jan Beulich wrote: >> Stop open-coding SHARED_M2P() and drop a pointless use of it from >> paging_mfn_is_dirty() (!VALID_M2P() is a superset of SHARED_M2P()) and >> another one from free_page_type() (prior assertions render this >> redunda

Re: [Xen-devel] [PATCH 5/6] x86/mm: clean up SHARED_M2P{, _ENTRY} uses

2017-12-12 Thread George Dunlap
On 12/12/2017 03:08 PM, Jan Beulich wrote: > Stop open-coding SHARED_M2P() and drop a pointless use of it from > paging_mfn_is_dirty() (!VALID_M2P() is a superset of SHARED_M2P()) and > another one from free_page_type() (prior assertions render this > redundant). > > Signed-off-by: Jan Beulich >

[Xen-devel] [PATCH 5/6] x86/mm: clean up SHARED_M2P{,_ENTRY} uses

2017-12-12 Thread Jan Beulich
Stop open-coding SHARED_M2P() and drop a pointless use of it from paging_mfn_is_dirty() (!VALID_M2P() is a superset of SHARED_M2P()) and another one from free_page_type() (prior assertions render this redundant). Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -2371