Re: [Xen-devel] [PATCH 4/6] VMX: correct PDPTE load checks

2018-08-30 Thread Jan Beulich
>>> On 28.08.18 at 15:12, wrote: > On 19/07/18 11:49, Jan Beulich wrote: >> Checking the low 5 bits of CR3 is not the job of vmx_load_pdptrs(). >> Instead it should #GP upon bad PDPTE values, rather than causing a VM >> entry failure. >> >> Signed-off-by: Jan Beulich >> >> --- a/xen/arch/x86/hvm/

Re: [Xen-devel] [PATCH 4/6] VMX: correct PDPTE load checks

2018-08-29 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Tuesday, August 28, 2018 9:12 PM > > +valid_mask = ((1ULL << v->domain->arch.cpuid->extd.maxphysaddr) - > 1) & > > + (PAGE_MASK | _PAGE_AVAIL | _PAGE_PRESENT); > > How did you come across this list?  The only vali

Re: [Xen-devel] [PATCH 4/6] VMX: correct PDPTE load checks

2018-08-28 Thread Andrew Cooper
On 19/07/18 11:49, Jan Beulich wrote: > Checking the low 5 bits of CR3 is not the job of vmx_load_pdptrs(). > Instead it should #GP upon bad PDPTE values, rather than causing a VM > entry failure. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.

[Xen-devel] [PATCH 4/6] VMX: correct PDPTE load checks

2018-07-19 Thread Jan Beulich
Checking the low 5 bits of CR3 is not the job of vmx_load_pdptrs(). Instead it should #GP upon bad PDPTE values, rather than causing a VM entry failure. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -1361,20 +1361,18 @@ static void vmx_set_interr