Re: [Xen-devel] [PATCH 3/5] x86/time: Rework pv_soft_rdtsc() to aid further cleanup

2018-02-23 Thread Jan Beulich
>>> On 20.02.18 at 12:58, wrote: > Having pv_soft_rdtsc() emulate all parts of an rdtscp is awkward, and gets in > the way of some intended cleanup. > > * Drop the rdtscp parameter and always make the caller responsible for ecx >updates when appropriate. > * Switch the function from being v

Re: [Xen-devel] [PATCH 3/5] x86/time: Rework pv_soft_rdtsc() to aid further cleanup

2018-02-20 Thread Andrew Cooper
On 20/02/18 16:04, Roger Pau Monné wrote: > On Tue, Feb 20, 2018 at 11:58:41AM +, Andrew Cooper wrote: >> Having pv_soft_rdtsc() emulate all parts of an rdtscp is awkward, and gets in >> the way of some intended cleanup. >> >> * Drop the rdtscp parameter and always make the caller responsible

Re: [Xen-devel] [PATCH 3/5] x86/time: Rework pv_soft_rdtsc() to aid further cleanup

2018-02-20 Thread Roger Pau Monné
On Tue, Feb 20, 2018 at 11:58:41AM +, Andrew Cooper wrote: > Having pv_soft_rdtsc() emulate all parts of an rdtscp is awkward, and gets in > the way of some intended cleanup. > > * Drop the rdtscp parameter and always make the caller responsible for ecx >updates when appropriate. > * Swi

Re: [Xen-devel] [PATCH 3/5] x86/time: Rework pv_soft_rdtsc() to aid further cleanup

2018-02-20 Thread Wei Liu
On Tue, Feb 20, 2018 at 11:58:41AM +, Andrew Cooper wrote: > Having pv_soft_rdtsc() emulate all parts of an rdtscp is awkward, and gets in > the way of some intended cleanup. > > * Drop the rdtscp parameter and always make the caller responsible for ecx >updates when appropriate. > * Swi

[Xen-devel] [PATCH 3/5] x86/time: Rework pv_soft_rdtsc() to aid further cleanup

2018-02-20 Thread Andrew Cooper
Having pv_soft_rdtsc() emulate all parts of an rdtscp is awkward, and gets in the way of some intended cleanup. * Drop the rdtscp parameter and always make the caller responsible for ecx updates when appropriate. * Switch the function from being void, and return the main timestamp in the r