Re: [Xen-devel] [PATCH 3/4] xen/public: Document HYPERCALL_console_io()

2019-08-05 Thread Jan Beulich
On 05.08.2019 12:17, Julien Grall wrote: > Hi Jan, > > On 05/08/2019 11:07, Jan Beulich wrote: >> On 05.08.2019 11:40, Julien Grall wrote: >>> Hi, >>> >>> On 09/04/2019 12:42, Jan Beulich wrote: >>> On 09.04.19 at 13:26, wrote: > On 03/04/2019 14:04, Jan Beulich wrote: >> Also please

Re: [Xen-devel] [PATCH 3/4] xen/public: Document HYPERCALL_console_io()

2019-08-05 Thread Julien Grall
Hi Jan, On 05/08/2019 11:07, Jan Beulich wrote: On 05.08.2019 11:40, Julien Grall wrote: Hi, On 09/04/2019 12:42, Jan Beulich wrote: On 09.04.19 at 13:26, wrote: On 03/04/2019 14:04, Jan Beulich wrote: Also please note the quotation used by the mentioned existing doc comments, as well as a

Re: [Xen-devel] [PATCH 3/4] xen/public: Document HYPERCALL_console_io()

2019-08-05 Thread Jan Beulich
On 05.08.2019 11:40, Julien Grall wrote: > Hi, > > On 09/04/2019 12:42, Jan Beulich wrote: > On 09.04.19 at 13:26, wrote: >>> On 03/04/2019 14:04, Jan Beulich wrote: Also please note the quotation used by the mentioned existing doc comments, as well as a few other formal aspects >>>

Re: [Xen-devel] [PATCH 3/4] xen/public: Document HYPERCALL_console_io()

2019-08-05 Thread Julien Grall
Hi, On 09/04/2019 12:42, Jan Beulich wrote: On 09.04.19 at 13:26, wrote: On 03/04/2019 14:04, Jan Beulich wrote: Also please note the quotation used by the mentioned existing doc comments, as well as a few other formal aspects (like them also making clear what the return type is). I think tha

Re: [Xen-devel] [PATCH 3/4] xen/public: Document HYPERCALL_console_io()

2019-04-25 Thread Jan Beulich
>>> On 16.04.19 at 11:54, wrote: > On 4/9/19 12:42 PM, Jan Beulich wrote: > On 09.04.19 at 13:26, wrote: >>> On 03/04/2019 14:04, Jan Beulich wrote: Also please note the quotation used by the mentioned existing doc comments, as well as a few other formal aspects (like them also

Re: [Xen-devel] [PATCH 3/4] xen/public: Document HYPERCALL_console_io()

2019-04-16 Thread Stefano Stabellini
On Tue, 2 Apr 2019, Julien Grall wrote: > Currently, OS developpers will have to look at Xen code in order to know > the parameters of an hypercall and how it is meant to work. > > This is not a trivial task as you may need to have a deep understanding > of Xen internal. > > This patch attempts t

Re: [Xen-devel] [PATCH 3/4] xen/public: Document HYPERCALL_console_io()

2019-04-16 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH 3/4] xen/public: Document HYPERCALL_console_io()"): > On 09.04.19 at 13:26, wrote: > > I haven't replicated the ` because I have no idea what they are used for. I > > would appreciate if you provide pointer how to use them. > > Well, I can only point you at the h

Re: [Xen-devel] [PATCH 3/4] xen/public: Document HYPERCALL_console_io()

2019-04-16 Thread Julien Grall
Hi Jan, On 4/9/19 12:42 PM, Jan Beulich wrote: On 09.04.19 at 13:26, wrote: On 03/04/2019 14:04, Jan Beulich wrote: Also please note the quotation used by the mentioned existing doc comments, as well as a few other formal aspects (like them also making clear what the return type is). I think

Re: [Xen-devel] [PATCH 3/4] xen/public: Document HYPERCALL_console_io()

2019-04-09 Thread Jan Beulich
>>> On 09.04.19 at 13:26, wrote: > On 03/04/2019 14:04, Jan Beulich wrote: >> Also please note the quotation used by the mentioned >> existing doc comments, as well as a few other formal aspects >> (like them also making clear what the return type is). I think >> that's a model used elsewhere as w

Re: [Xen-devel] [PATCH 3/4] xen/public: Document HYPERCALL_console_io()

2019-04-09 Thread Julien Grall
Hi Jan, On 03/04/2019 14:04, Jan Beulich wrote: On 02.04.19 at 18:42, wrote: --- a/xen/include/public/xen.h +++ b/xen/include/public/xen.h @@ -97,6 +97,7 @@ DEFINE_XEN_GUEST_HANDLE(xen_ulong_t); #define __HYPERVISOR_set_timer_op 15 #define __HYPERVISOR_event_channel_op_compat 16 /*

Re: [Xen-devel] [PATCH 3/4] xen/public: Document HYPERCALL_console_io()

2019-04-03 Thread Jan Beulich
>>> On 02.04.19 at 18:42, wrote: > --- a/xen/include/public/xen.h > +++ b/xen/include/public/xen.h > @@ -97,6 +97,7 @@ DEFINE_XEN_GUEST_HANDLE(xen_ulong_t); > #define __HYPERVISOR_set_timer_op 15 > #define __HYPERVISOR_event_channel_op_compat 16 /* compat since 0x00030202 */ > #define _

Re: [Xen-devel] [PATCH 3/4] xen/public: Document HYPERCALL_console_io()

2019-04-03 Thread Wei Liu
On Tue, Apr 02, 2019 at 05:42:37PM +0100, Julien Grall wrote: > Currently, OS developpers will have to look at Xen code in order to know > the parameters of an hypercall and how it is meant to work. > > This is not a trivial task as you may need to have a deep understanding > of Xen internal. > >

[Xen-devel] [PATCH 3/4] xen/public: Document HYPERCALL_console_io()

2019-04-02 Thread Julien Grall
Currently, OS developpers will have to look at Xen code in order to know the parameters of an hypercall and how it is meant to work. This is not a trivial task as you may need to have a deep understanding of Xen internal. This patch attempts to document the behavior of HYPERCALL_console_io() to h