Re: [Xen-devel] [PATCH 3/3] x86/svm: correct EFER.SVME intercept checks

2018-02-05 Thread Jan Beulich
>>> On 03.02.18 at 18:15, wrote: > On 02/03/2018 12:10 PM, Andrew Cooper wrote: >> On 03/02/18 17:03, Boris Ostrovsky wrote: >>> >>> >>> On 01/31/2018 03:35 PM, Brian Woods wrote: Corrects some EFER.SVME checks in intercepts. See AMD APM vol2 section 15.4 for more details. VMMCALL isn'

Re: [Xen-devel] [PATCH 3/3] x86/svm: correct EFER.SVME intercept checks

2018-02-03 Thread Boris Ostrovsky
On 02/03/2018 12:10 PM, Andrew Cooper wrote: On 03/02/18 17:03, Boris Ostrovsky wrote: On 01/31/2018 03:35 PM, Brian Woods wrote: Corrects some EFER.SVME checks in intercepts.  See AMD APM vol2 section 15.4 for more details.  VMMCALL isn't checked due to guests needing it to boot. Don't

Re: [Xen-devel] [PATCH 3/3] x86/svm: correct EFER.SVME intercept checks

2018-02-03 Thread Andrew Cooper
On 03/02/18 17:03, Boris Ostrovsky wrote: > > > On 01/31/2018 03:35 PM, Brian Woods wrote: >> Corrects some EFER.SVME checks in intercepts.  See AMD APM vol2 section >> 15.4 for more details.  VMMCALL isn't checked due to guests needing it >> to boot. >> > > Don't you need SVME be on for VMMCALL?

Re: [Xen-devel] [PATCH 3/3] x86/svm: correct EFER.SVME intercept checks

2018-02-03 Thread Boris Ostrovsky
On 01/31/2018 03:35 PM, Brian Woods wrote: Corrects some EFER.SVME checks in intercepts. See AMD APM vol2 section 15.4 for more details. VMMCALL isn't checked due to guests needing it to boot. Don't you need SVME be on for VMMCALL? -boris ___

[Xen-devel] [PATCH 3/3] x86/svm: correct EFER.SVME intercept checks

2018-01-31 Thread Brian Woods
Corrects some EFER.SVME checks in intercepts. See AMD APM vol2 section 15.4 for more details. VMMCALL isn't checked due to guests needing it to boot. Reported-by: Andrew Cooper Signed-off-by: Brian Woods --- xen/arch/x86/hvm/svm/nestedsvm.c | 10 -- xen/arch/x86/hvm/svm/svm.c |