Re: [Xen-devel] [PATCH 24/57] ARM: timer: Handle level triggered IRQs correctly

2018-03-06 Thread Julien Grall
On 06/03/18 17:15, Julien Grall wrote: On 05/03/18 16:03, Andre Przywara wrote:   /*    * Arch timer interrupt really ought to be level triggered, since the    * design of the timer/comparator mechanism is based around that diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 7411bff7a

Re: [Xen-devel] [PATCH 24/57] ARM: timer: Handle level triggered IRQs correctly

2018-03-06 Thread Julien Grall
Hi Andre, On 05/03/18 16:03, Andre Przywara wrote: The ARM Generic Timer uses a level-sensitive interrupt semantic. We easily catch when the line goes high, as this triggers the hardware IRQ. However we have to sync the state of the interrupt condition at certain points to catch when the line go

[Xen-devel] [PATCH 24/57] ARM: timer: Handle level triggered IRQs correctly

2018-03-05 Thread Andre Przywara
The ARM Generic Timer uses a level-sensitive interrupt semantic. We easily catch when the line goes high, as this triggers the hardware IRQ. However we have to sync the state of the interrupt condition at certain points to catch when the line goes low and we can remove the vtimer vIRQ from the vGIC