Re: [Xen-devel] [PATCH 2/6] x86/msr: Cleanup of misc constants

2018-06-27 Thread Roger Pau Monné
On Tue, Jun 26, 2018 at 02:18:14PM +0100, Andrew Cooper wrote: > Begin the process of cleaning up msr-index.h. Order the MSRs at the > head of the file by index, use spaces for indentation, _AC() for bit > positions, and add a comment describing the expected style. Abbreviate > the ARCH_CAPS_* co

Re: [Xen-devel] [PATCH 2/6] x86/msr: Cleanup of misc constants

2018-06-26 Thread Wei Liu
On Tue, Jun 26, 2018 at 02:18:14PM +0100, Andrew Cooper wrote: > Begin the process of cleaning up msr-index.h. Order the MSRs at the > head of the file by index, use spaces for indentation, _AC() for bit > positions, and add a comment describing the expected style. Abbreviate > the ARCH_CAPS_* co

[Xen-devel] [PATCH 2/6] x86/msr: Cleanup of misc constants

2018-06-26 Thread Andrew Cooper
Begin the process of cleaning up msr-index.h. Order the MSRs at the head of the file by index, use spaces for indentation, _AC() for bit positions, and add a comment describing the expected style. Abbreviate the ARCH_CAPS_* constants to reduce code volume. Leave a trailing comment to logically s