Re: [Xen-devel] [PATCH 2/4] x86/cpuid: Drop get_cpu_vendor() completely

2019-03-26 Thread Andrew Cooper
On 26/03/2019 12:08, Jan Beulich wrote: On 21.03.19 at 13:21, wrote: >> get_cpu_vendor() tries to do a number of things, and ends up doing none of >> them well. >> >> For calculating the vendor itself, use x86_cpuid_lookup_vendor() which is >> implemented in a far more efficient manner than l

Re: [Xen-devel] [PATCH 2/4] x86/cpuid: Drop get_cpu_vendor() completely

2019-03-26 Thread Jan Beulich
>>> On 21.03.19 at 13:21, wrote: > get_cpu_vendor() tries to do a number of things, and ends up doing none of > them well. > > For calculating the vendor itself, use x86_cpuid_lookup_vendor() which is > implemented in a far more efficient manner than looping over cpu_devs[]. Well, yes, the new l

[Xen-devel] [PATCH 2/4] x86/cpuid: Drop get_cpu_vendor() completely

2019-03-21 Thread Andrew Cooper
get_cpu_vendor() tries to do a number of things, and ends up doing none of them well. For calculating the vendor itself, use x86_cpuid_lookup_vendor() which is implemented in a far more efficient manner than looping over cpu_devs[]. For setting up this_cpu, set it up once on the BSP only, rather