Re: [Xen-devel] [PATCH 2/3 v3] xen: Add support for initializing 16550 UART using ACPI

2017-11-27 Thread Jan Beulich
>>> On 24.11.17 at 12:39, wrote: > --- a/xen/drivers/char/ns16550.c > +++ b/xen/drivers/char/ns16550.c > @@ -29,6 +29,10 @@ > #ifdef CONFIG_X86 > #include > #endif > +#ifdef CONFIG_ACPI > +#include > +#endif > + > > /* No double blank lines please. Jan _

Re: [Xen-devel] [PATCH 2/3 v3] xen: Add support for initializing 16550 UART using ACPI

2017-11-24 Thread Julien Grall
Hi Bhupinder, On 24/11/17 11:39, Bhupinder Thakur wrote: Currently, Xen supports only DT based initialization of 16550 UART. This patch adds support for initializing 16550 UART using ACPI SPCR table. Signed-off-by: Bhupinder Thakur --- Changes since v2: - renamed UART_MAX_REG to UART_NUM_REGS

Re: [Xen-devel] [PATCH 2/3 v3] xen: Add support for initializing 16550 UART using ACPI

2017-11-24 Thread Julien Grall
Hi, On 24/11/17 15:11, Andre Przywara wrote: On 24/11/17 13:50, Konrad Rzeszutek Wilk wrote: On Fri, Nov 24, 2017 at 05:09:11PM +0530, Bhupinder Thakur wrote: diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index c5dfc1e..af4712f 100644 --- a/xen/drivers/char/ns16550.c +++

Re: [Xen-devel] [PATCH 2/3 v3] xen: Add support for initializing 16550 UART using ACPI

2017-11-24 Thread Andre Przywara
Hi, (answering to both Konrad and Bhupinder ...) On 24/11/17 13:50, Konrad Rzeszutek Wilk wrote: > On Fri, Nov 24, 2017 at 05:09:11PM +0530, Bhupinder Thakur wrote: >> Currently, Xen supports only DT based initialization of 16550 UART. >> This patch adds support for initializing 16550 UART using

Re: [Xen-devel] [PATCH 2/3 v3] xen: Add support for initializing 16550 UART using ACPI

2017-11-24 Thread Konrad Rzeszutek Wilk
On Fri, Nov 24, 2017 at 05:09:11PM +0530, Bhupinder Thakur wrote: > Currently, Xen supports only DT based initialization of 16550 UART. > This patch adds support for initializing 16550 UART using ACPI SPCR table. Can you provide the link to the spec you are using. I am wondering if I am looking at

[Xen-devel] [PATCH 2/3 v3] xen: Add support for initializing 16550 UART using ACPI

2017-11-24 Thread Bhupinder Thakur
Currently, Xen supports only DT based initialization of 16550 UART. This patch adds support for initializing 16550 UART using ACPI SPCR table. Signed-off-by: Bhupinder Thakur --- Changes since v2: - renamed UART_MAX_REG to UART_NUM_REGS - aligned some assignment statements - some coding style cha