Re: [Xen-devel] [PATCH 2/3] x86/nvmx: clarify and fix usage of nvmx_update_apicv

> From: Roger Pau Monné > Sent: Tuesday, March 24, 2020 8:19 PM > > On Tue, Mar 24, 2020 at 11:33:00AM +, Tian, Kevin wrote: > > > From: Roger Pau Monné > > > Sent: Tuesday, March 24, 2020 7:23 PM > > > > > > On Tue, Mar 24, 2020 at 10:11:15AM +, Tian, Kevin wrote: > > > > > From: Roger

Re: [Xen-devel] [PATCH 2/3] x86/nvmx: clarify and fix usage of nvmx_update_apicv

On Tue, Mar 24, 2020 at 11:33:00AM +, Tian, Kevin wrote: > > From: Roger Pau Monné > > Sent: Tuesday, March 24, 2020 7:23 PM > > > > On Tue, Mar 24, 2020 at 10:11:15AM +, Tian, Kevin wrote: > > > > From: Roger Pau Monné > > > > Sent: Tuesday, March 24, 2020 5:51 PM > > > > > > > > On Tue

Re: [Xen-devel] [PATCH 2/3] x86/nvmx: clarify and fix usage of nvmx_update_apicv

> From: Roger Pau Monné > Sent: Tuesday, March 24, 2020 7:23 PM > > On Tue, Mar 24, 2020 at 10:11:15AM +, Tian, Kevin wrote: > > > From: Roger Pau Monné > > > Sent: Tuesday, March 24, 2020 5:51 PM > > > > > > On Tue, Mar 24, 2020 at 06:03:28AM +, Tian, Kevin wrote: > > > > > From: Roger

Re: [Xen-devel] [PATCH 2/3] x86/nvmx: clarify and fix usage of nvmx_update_apicv

On Tue, Mar 24, 2020 at 10:11:15AM +, Tian, Kevin wrote: > > From: Roger Pau Monné > > Sent: Tuesday, March 24, 2020 5:51 PM > > > > On Tue, Mar 24, 2020 at 06:03:28AM +, Tian, Kevin wrote: > > > > From: Roger Pau Monne > > > > Sent: Saturday, March 21, 2020 3:08 AM > > > > > > > > The c

Re: [Xen-devel] [PATCH 2/3] x86/nvmx: clarify and fix usage of nvmx_update_apicv

> From: Roger Pau Monné > Sent: Tuesday, March 24, 2020 5:51 PM > > On Tue, Mar 24, 2020 at 06:03:28AM +, Tian, Kevin wrote: > > > From: Roger Pau Monne > > > Sent: Saturday, March 21, 2020 3:08 AM > > > > > > The current usage of nvmx_update_apicv is not clear: it is deeply > > > intertwine

Re: [Xen-devel] [PATCH 2/3] x86/nvmx: clarify and fix usage of nvmx_update_apicv

On Tue, Mar 24, 2020 at 06:03:28AM +, Tian, Kevin wrote: > > From: Roger Pau Monne > > Sent: Saturday, March 21, 2020 3:08 AM > > > > The current usage of nvmx_update_apicv is not clear: it is deeply > > intertwined with the Ack interrupt on exit VMEXIT control. > > > > The code in nvmx_upda

Re: [Xen-devel] [PATCH 2/3] x86/nvmx: clarify and fix usage of nvmx_update_apicv

> From: Roger Pau Monne > Sent: Saturday, March 21, 2020 3:08 AM > > The current usage of nvmx_update_apicv is not clear: it is deeply > intertwined with the Ack interrupt on exit VMEXIT control. > > The code in nvmx_update_apicv should update the SVI (in service interrupt) > field of the guest

[Xen-devel] [PATCH 2/3] x86/nvmx: clarify and fix usage of nvmx_update_apicv

The current usage of nvmx_update_apicv is not clear: it is deeply intertwined with the Ack interrupt on exit VMEXIT control. The code in nvmx_update_apicv should update the SVI (in service interrupt) field of the guest interrupt status only when the Ack interrupt on exit is set, as it is used to r