Re: [Xen-devel] [PATCH 13/15] x86/xstate: Add Hygon Dhyana support

2019-01-30 Thread Pu Wen
On 2019/1/29 19:15, Jan Beulich wrote: Pu Wen 12/20/18 2:16 PM >>> >> --- a/xen/arch/x86/xstate.c >> +++ b/xen/arch/x86/xstate.c >> @@ -369,7 +369,7 @@ void xrstor(struct vcpu *v, uint64_t mask) >> unsigned int faults, prev_faults; > > >> /* >> - * AMD CPUs don't save/restore FDP/FIP/FO

Re: [Xen-devel] [PATCH 13/15] x86/xstate: Add Hygon Dhyana support

2019-01-29 Thread Jan Beulich
>>> Pu Wen 12/20/18 2:16 PM >>> >--- a/xen/arch/x86/xstate.c >+++ b/xen/arch/x86/xstate.c >@@ -369,7 +369,7 @@ void xrstor(struct vcpu *v, uint64_t mask) >unsigned int faults, prev_faults; > >/* >- * AMD CPUs don't save/restore FDP/FIP/FOP unless an exception >+ * AMD or Hygon CPUs don't

Re: [Xen-devel] [PATCH 13/15] x86/xstate: Add Hygon Dhyana support

2018-12-29 Thread Pu Wen
On 2018/12/28 6:41, Andrew Cooper wrote: > On 20/12/2018 13:15, Pu Wen wrote: >> The Hygon Dhyana CPU don't save/restore FDP/FIP/FOP unless an exception >> is pending. So add support for it in the function xrstor. > > Really? > > Zen was the first AMD processor to fix this (mis)feature, and the X

Re: [Xen-devel] [PATCH 13/15] x86/xstate: Add Hygon Dhyana support

2018-12-27 Thread Andrew Cooper
On 20/12/2018 13:15, Pu Wen wrote: > The Hygon Dhyana CPU don't save/restore FDP/FIP/FOP unless an exception > is pending. So add support for it in the function xrstor. Really? Zen was the first AMD processor to fix this (mis)feature, and the Xen code doesn't appear to have caught up yet. I'm pu

[Xen-devel] [PATCH 13/15] x86/xstate: Add Hygon Dhyana support

2018-12-20 Thread Pu Wen
The Hygon Dhyana CPU don't save/restore FDP/FIP/FOP unless an exception is pending. So add support for it in the function xrstor. Signed-off-by: Pu Wen --- xen/arch/x86/xstate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c