Re: [Xen-devel] [PATCH 1/2] xen/sched: fix locking in restore_vcpu_affinity()

2019-07-23 Thread Andrew Cooper
On 23/07/2019 13:08, Jan Beulich wrote: > On 23.07.2019 11:20, Juergen Gross wrote: >> --- a/xen/common/schedule.c >> +++ b/xen/common/schedule.c >> @@ -708,6 +708,8 @@ void restore_vcpu_affinity(struct domain *d) >>* set v->processor of each of their vCPUs to something that will >>

Re: [Xen-devel] [PATCH 1/2] xen/sched: fix locking in restore_vcpu_affinity()

2019-07-23 Thread Jan Beulich
On 23.07.2019 11:20, Juergen Gross wrote: > --- a/xen/common/schedule.c > +++ b/xen/common/schedule.c > @@ -708,6 +708,8 @@ void restore_vcpu_affinity(struct domain *d) >* set v->processor of each of their vCPUs to something that will >* make sense for the scheduler of the c

Re: [Xen-devel] [PATCH 1/2] xen/sched: fix locking in restore_vcpu_affinity()

2019-07-23 Thread Juergen Gross
On 23.07.19 14:08, Jan Beulich wrote: On 23.07.2019 11:20, Juergen Gross wrote: --- a/xen/common/schedule.c +++ b/xen/common/schedule.c @@ -708,6 +708,8 @@ void restore_vcpu_affinity(struct domain *d) * set v->processor of each of their vCPUs to something that will * make

Re: [Xen-devel] [PATCH 1/2] xen/sched: fix locking in restore_vcpu_affinity()

2019-07-23 Thread Dario Faggioli
On Tue, 2019-07-23 at 11:20 +0200, Juergen Gross wrote: > Commit 0763cd2687897b55e7 ("xen/sched: don't disable scheduler on > cpus > during suspend") removed a lock in restore_vcpu_affinity() which > needs > to stay: cpumask_scratch_cpu() must be protected by the scheduler > lock. > And indeed I r

[Xen-devel] [PATCH 1/2] xen/sched: fix locking in restore_vcpu_affinity()

2019-07-23 Thread Juergen Gross
Commit 0763cd2687897b55e7 ("xen/sched: don't disable scheduler on cpus during suspend") removed a lock in restore_vcpu_affinity() which needs to stay: cpumask_scratch_cpu() must be protected by the scheduler lock. restore_vcpu_affinity() is being called by thaw_domains(), so with multiple domains i