Re: [Xen-devel] [PATCH 1/2] x86/E820: don't overrun array

2017-12-20 Thread Andrew Cooper
On 12/12/17 14:21, Jan Beulich wrote: On 12.12.17 at 12:18, wrote: >> On 12/12/17 11:10, Jan Beulich wrote: >>> The bounds check needs to be done after the increment, not before, or >>> else it needs to use a one lower immediate. Also use word operations >>> rather than byte ones for both the

Re: [Xen-devel] [PATCH 1/2] x86/E820: don't overrun array

2017-12-12 Thread Jan Beulich
>>> On 12.12.17 at 12:18, wrote: > On 12/12/17 11:10, Jan Beulich wrote: >> The bounds check needs to be done after the increment, not before, or >> else it needs to use a one lower immediate. Also use word operations >> rather than byte ones for both the increment and the compare (allowing >> E82

Re: [Xen-devel] [PATCH 1/2] x86/E820: don't overrun array

2017-12-12 Thread Andrew Cooper
On 12/12/17 11:10, Jan Beulich wrote: > The bounds check needs to be done after the increment, not before, or > else it needs to use a one lower immediate. Also use word operations > rather than byte ones for both the increment and the compare (allowing > E820_BIOS_MAX to be more easily bumped, sho

[Xen-devel] [PATCH 1/2] x86/E820: don't overrun array

2017-12-12 Thread Jan Beulich
The bounds check needs to be done after the increment, not before, or else it needs to use a one lower immediate. Also use word operations rather than byte ones for both the increment and the compare (allowing E820_BIOS_MAX to be more easily bumped, should the need ever arise). Signed-off-by: Jan