Re: [Xen-devel] [PATCH-for-4.13 v2] x86/mm: don't needlessly veto migration

2019-10-08 Thread Paul Durrant
On Tue, 8 Oct 2019 at 09:25, Jan Beulich wrote: > > On 01.10.2019 17:11, Paul Durrant wrote: > > --- a/xen/arch/x86/mm/paging.c > > +++ b/xen/arch/x86/mm/paging.c > > @@ -209,15 +209,15 @@ static int paging_free_log_dirty_bitmap(struct domain > > *d, int rc) > > return rc; > > } > > > > -in

Re: [Xen-devel] [PATCH-for-4.13 v2] x86/mm: don't needlessly veto migration

2019-10-08 Thread Jan Beulich
On 01.10.2019 17:11, Paul Durrant wrote: > --- a/xen/arch/x86/mm/paging.c > +++ b/xen/arch/x86/mm/paging.c > @@ -209,15 +209,15 @@ static int paging_free_log_dirty_bitmap(struct domain > *d, int rc) > return rc; > } > > -int paging_log_dirty_enable(struct domain *d, bool_t log_global) > +i

Re: [Xen-devel] [PATCH-for-4.13 v2] x86/mm: don't needlessly veto migration

2019-10-04 Thread George Dunlap
On 10/2/19 10:10 AM, Andrew Cooper wrote: > On 02/10/2019 09:40, Jan Beulich wrote: >> On 01.10.2019 17:11, Paul Durrant wrote: >>> Now that xl.cfg has an option to explicitly enable IOMMU mappings for a >>> domain, migration may be needlessly vetoed due to the check of >>> is_iommu_enabled() in pa

Re: [Xen-devel] [PATCH-for-4.13 v2] x86/mm: don't needlessly veto migration

2019-10-02 Thread Paul Durrant
On Wed, 2 Oct 2019 at 10:42, Jan Beulich wrote: > > On 02.10.2019 11:10, Andrew Cooper wrote: > > On 02/10/2019 09:40, Jan Beulich wrote: > >> On 01.10.2019 17:11, Paul Durrant wrote: > >>> Now that xl.cfg has an option to explicitly enable IOMMU mappings for a > >>> domain, migration may be needl

Re: [Xen-devel] [PATCH-for-4.13 v2] x86/mm: don't needlessly veto migration

2019-10-02 Thread Jan Beulich
On 02.10.2019 11:10, Andrew Cooper wrote: > On 02/10/2019 09:40, Jan Beulich wrote: >> On 01.10.2019 17:11, Paul Durrant wrote: >>> Now that xl.cfg has an option to explicitly enable IOMMU mappings for a >>> domain, migration may be needlessly vetoed due to the check of >>> is_iommu_enabled() in pa

Re: [Xen-devel] [PATCH-for-4.13 v2] x86/mm: don't needlessly veto migration

2019-10-02 Thread Paul Durrant
On Wed, 2 Oct 2019 at 10:12, Andrew Cooper wrote: > > On 02/10/2019 09:40, Jan Beulich wrote: > > On 01.10.2019 17:11, Paul Durrant wrote: > >> Now that xl.cfg has an option to explicitly enable IOMMU mappings for a > >> domain, migration may be needlessly vetoed due to the check of > >> is_iommu_

Re: [Xen-devel] [PATCH-for-4.13 v2] x86/mm: don't needlessly veto migration

2019-10-02 Thread Paul Durrant
On Wed, 2 Oct 2019 at 10:26, Jan Beulich wrote: > > On 02.10.2019 10:59, Paul Durrant wrote: > > On Wed, 2 Oct 2019 at 09:42, Jan Beulich wrote: > >> > >> On 01.10.2019 17:11, Paul Durrant wrote: > >>> Now that xl.cfg has an option to explicitly enable IOMMU mappings for a > >>> domain, migration

Re: [Xen-devel] [PATCH-for-4.13 v2] x86/mm: don't needlessly veto migration

2019-10-02 Thread Jan Beulich
On 02.10.2019 10:59, Paul Durrant wrote: > On Wed, 2 Oct 2019 at 09:42, Jan Beulich wrote: >> >> On 01.10.2019 17:11, Paul Durrant wrote: >>> Now that xl.cfg has an option to explicitly enable IOMMU mappings for a >>> domain, migration may be needlessly vetoed due to the check of >>> is_iommu_enab

Re: [Xen-devel] [PATCH-for-4.13 v2] x86/mm: don't needlessly veto migration

2019-10-02 Thread Andrew Cooper
On 02/10/2019 09:40, Jan Beulich wrote: > On 01.10.2019 17:11, Paul Durrant wrote: >> Now that xl.cfg has an option to explicitly enable IOMMU mappings for a >> domain, migration may be needlessly vetoed due to the check of >> is_iommu_enabled() in paging_log_dirty_enable(). >> There is actually no

Re: [Xen-devel] [PATCH-for-4.13 v2] x86/mm: don't needlessly veto migration

2019-10-02 Thread Paul Durrant
On Wed, 2 Oct 2019 at 09:42, Jan Beulich wrote: > > On 01.10.2019 17:11, Paul Durrant wrote: > > Now that xl.cfg has an option to explicitly enable IOMMU mappings for a > > domain, migration may be needlessly vetoed due to the check of > > is_iommu_enabled() in paging_log_dirty_enable(). > > There

Re: [Xen-devel] [PATCH-for-4.13 v2] x86/mm: don't needlessly veto migration

2019-10-02 Thread Jan Beulich
On 01.10.2019 17:11, Paul Durrant wrote: > Now that xl.cfg has an option to explicitly enable IOMMU mappings for a > domain, migration may be needlessly vetoed due to the check of > is_iommu_enabled() in paging_log_dirty_enable(). > There is actually no need to prevent logdirty from being enabled u

[Xen-devel] [PATCH-for-4.13 v2] x86/mm: don't needlessly veto migration

2019-10-01 Thread Paul Durrant
Now that xl.cfg has an option to explicitly enable IOMMU mappings for a domain, migration may be needlessly vetoed due to the check of is_iommu_enabled() in paging_log_dirty_enable(). There is actually no need to prevent logdirty from being enabled unless devices are assigned to a domain and that d