Re: [Xen-devel] [PATCH] xen/x86: Drop unnecessary barriers

2018-01-02 Thread Jan Beulich
>>> On 02.01.18 at 15:17, wrote: > x86's current implementation of wmb() is a compiler barrier. As a result, the > only change in this patch is to remove an mfence instruction from > cpuidle_disable_deep_cstate(). > > None of these barriers serve any purpose. They are not synchronising with > r

[Xen-devel] [PATCH] xen/x86: Drop unnecessary barriers

2018-01-02 Thread Andrew Cooper
x86's current implementation of wmb() is a compiler barrier. As a result, the only change in this patch is to remove an mfence instruction from cpuidle_disable_deep_cstate(). None of these barriers serve any purpose. They are not synchronising with remote cpus, and their compiler-barrier propert