Re: [Xen-devel] [PATCH] xen/sched: remove wrong assertions in csched2_free_pdata()

2019-11-12 Thread Dario Faggioli
On Fri, 2019-11-08 at 08:38 +0100, Juergen Gross wrote: > The assertions in csched2_free_pdata() are wrong as in case it is > called by schedule_cpu_add() after a failure of sched_alloc_udata() > the init pdata function won't have been called. > Sorry, maybe too much time has passed since when I w

Re: [Xen-devel] [PATCH] xen/sched: remove wrong assertions in csched2_free_pdata()

2019-11-12 Thread Jürgen Groß
On 12.11.19 16:52, George Dunlap wrote: On Nov 8, 2019, at 7:38 AM, Juergen Gross wrote: The assertions in csched2_free_pdata() are wrong as in case it is called by schedule_cpu_add() after a failure of sched_alloc_udata() the init pdata function won't have been called. I’m a bit confused

Re: [Xen-devel] [PATCH] xen/sched: remove wrong assertions in csched2_free_pdata()

2019-11-12 Thread George Dunlap
> On Nov 8, 2019, at 7:38 AM, Juergen Gross wrote: > > The assertions in csched2_free_pdata() are wrong as in case it is > called by schedule_cpu_add() after a failure of sched_alloc_udata() > the init pdata function won't have been called. I’m a bit confused by this, as the comment says that

[Xen-devel] [PATCH] xen/sched: remove wrong assertions in csched2_free_pdata()

2019-11-07 Thread Juergen Gross
The assertions in csched2_free_pdata() are wrong as in case it is called by schedule_cpu_add() after a failure of sched_alloc_udata() the init pdata function won't have been called. So just remove the (wrong) comment and ASSERT() statements. While at it remove the wrong comment in csched2_deinit_