Re: [Xen-devel] [PATCH] xen/sched: remove pointless ASSERT() in credit2

2020-02-11 Thread Dario Faggioli
On Tue, 2020-02-11 at 10:36 +0100, Jürgen Groß wrote: > On 11.02.20 10:29, Dario Faggioli wrote: > > > > TBH, though, considering the nature of the check, I'd rather keep > > the > > ASSERT() and kill the BUG_ON(). > > > > I can do the patch myself if you don't want to respin it that way. > > I'

Re: [Xen-devel] [PATCH] xen/sched: remove pointless ASSERT() in credit2

2020-02-11 Thread Jürgen Groß
On 11.02.20 10:29, Dario Faggioli wrote: On Mon, 2020-02-10 at 17:45 +0100, Juergen Gross wrote: The ASSERT() at the top of csched2_context_saved() is completely pointless, as the BUG_ON() just in front of it catches the same problem already. Yep, I went double checking and this is my fault. :

Re: [Xen-devel] [PATCH] xen/sched: remove pointless ASSERT() in credit2

2020-02-11 Thread Dario Faggioli
On Mon, 2020-02-10 at 17:45 +0100, Juergen Gross wrote: > The ASSERT() at the top of csched2_context_saved() is completely > pointless, as the BUG_ON() just in front of it catches the same > problem > already. > Yep, I went double checking and this is my fault. :-( Apparently, in ccf2ead7f52 ("xe

[Xen-devel] [PATCH] xen/sched: remove pointless ASSERT() in credit2

2020-02-10 Thread Juergen Gross
The ASSERT() at the top of csched2_context_saved() is completely pointless, as the BUG_ON() just in front of it catches the same problem already. While at it remove a bogus space in the BUG_ON(). Signed-off-by: Juergen Gross --- xen/common/sched/credit2.c | 6 ++ 1 file changed, 2 insertion