Re: [Xen-devel] [PATCH] xen/sched: fix credit2 smt idle handling

2019-03-25 Thread Juergen Gross
On 25/03/2019 11:53, Dario Faggioli wrote: > On Sat, 2019-03-23 at 14:22 +0100, Juergen Gross wrote: >> On 23/03/2019 03:32, Dario Faggioli wrote: >>> To properly deal with offline CPUs, I think we can change the logic >>> a >>> little, i.e., we initialize the smt_idle mask to all-1 (all CPUs >>> i

Re: [Xen-devel] [PATCH] xen/sched: fix credit2 smt idle handling

2019-03-25 Thread Dario Faggioli
On Sat, 2019-03-23 at 14:22 +0100, Juergen Gross wrote: > On 23/03/2019 03:32, Dario Faggioli wrote: > > To properly deal with offline CPUs, I think we can change the logic > > a > > little, i.e., we initialize the smt_idle mask to all-1 (all CPUs > > idle), > > and we also make sure that we set th

Re: [Xen-devel] [PATCH] xen/sched: fix credit2 smt idle handling

2019-03-23 Thread Juergen Gross
On 23/03/2019 03:32, Dario Faggioli wrote: > On Fri, 2019-03-22 at 10:04 +0100, Juergen Gross wrote: >> Credit2's smt_idle_mask_set() and smt_idle_mask_clear() are used to >> identify idle cores where vcpus can be moved to. A core is thought to >> be idle when all siblings are known to have the idl

Re: [Xen-devel] [PATCH] xen/sched: fix credit2 smt idle handling

2019-03-23 Thread Dario Faggioli
On Sat, 2019-03-23 at 03:32 +0100, Dario Faggioli wrote: > On Fri, 2019-03-22 at 10:04 +0100, Juergen Gross wrote: > > This problem can be solved by and-ing the core's sibling cpumask > > with > > the runqueue's active mask before doing the idle test. > > > > Therefore, I'm a bit reluctant at add

Re: [Xen-devel] [PATCH] xen/sched: fix credit2 smt idle handling

2019-03-22 Thread Dario Faggioli
On Fri, 2019-03-22 at 10:04 +0100, Juergen Gross wrote: > Credit2's smt_idle_mask_set() and smt_idle_mask_clear() are used to > identify idle cores where vcpus can be moved to. A core is thought to > be idle when all siblings are known to have the idle vcpu running on > them. > > Unfortunately the

[Xen-devel] [PATCH] xen/sched: fix credit2 smt idle handling

2019-03-22 Thread Juergen Gross
Credit2's smt_idle_mask_set() and smt_idle_mask_clear() are used to identify idle cores where vcpus can be moved to. A core is thought to be idle when all siblings are known to have the idle vcpu running on them. Unfortunately the information of a vcpu running on a cpu is per runqueue. So in case