Re: [Xen-devel] [PATCH] xen/arm: Surround HSR_SYSREG macro value with ()

2017-12-08 Thread Stefano Stabellini
On Fri, 8 Dec 2017, Julien Grall wrote: > Hi, > > Ping? > > Cheers, > > On 29/11/17 17:46, Julien Grall wrote: > > The value of the macro HCR_SYSREG is not surrounded by (). This means > > the behavior may change depend on how it is used. > > > > Thanksfully recent GCC will issue a warning for

Re: [Xen-devel] [PATCH] xen/arm: Surround HSR_SYSREG macro value with ()

2017-12-08 Thread Julien Grall
Hi, Ping? Cheers, On 29/11/17 17:46, Julien Grall wrote: The value of the macro HCR_SYSREG is not surrounded by (). This means the behavior may change depend on how it is used. Thanksfully recent GCC will issue a warning for that. Signed-off-by: Julien Grall --- I am not aware of any "bad

[Xen-devel] [PATCH] xen/arm: Surround HSR_SYSREG macro value with ()

2017-11-29 Thread Julien Grall
The value of the macro HCR_SYSREG is not surrounded by (). This means the behavior may change depend on how it is used. Thanksfully recent GCC will issue a warning for that. Signed-off-by: Julien Grall --- I am not aware of any "bad" usage today in Xen. This was found whilst playing with sysre